fix: flickering loading indicator on batch delete #10763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the flickering loading indicator when batch deleting a bunch of files. Since delete operations are running in parallel, using the `setProgress` method for the loading indicator won't work. This is only suited for serial requests. Also adds a concurrent request limit via pqueue. This stops the network from being overrun with concurrent requests.
JammingBen
force-pushed
the
batch-delete-perf
branch
from
a40d748 to
9584ab2
Compare
|
AlexAndBear
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the flickering loading indicator when batch deleting a bunch of files. Since delete operations are running in parallel, using the
setProgressmethod for the loading indicator won't work. This is only suited for serial requests.Also adds a concurrent request limit via pqueue. This stops the network from being overrun with concurrent requests.
Related Issue
Types of changes