refactor: remove owncloud-sdk

.npmrc

@@ -1,9 +1,6 @@
 auto-install-peers=true
 shared-workspace-lockfile=true
 
-# apps
-public-hoist-pattern[]=owncloud-sdk
-
 # @vue/component-compiler-utils
 hoist-pattern[]=sass
 

index.html

@@ -19,7 +19,7 @@
   <% } %>
     <script type="module" src="./packages/web-runtime/src/index.ts"></script>
     <script type="module">
-      // Fix Buffer usage in or indirectly via owncloud-sdk in production (!)
+      // Fix Buffer usage in production (!)
       // If single file downloads work in production after removing this, it can probably be removed permanently
       import { Buffer } from "buffer";
       window.Buffer = Buffer;

packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue

@@ -227,21 +227,8 @@ export default defineComponent({
       })
     }
     const notifyShare = async () => {
-      try {
-        const response = await clientService.owncloudSdk.shares.notifyShare(props.share.id)
-        showMessage({
-          title: $gettext('Success'),
-          desc: $gettext('Email reminder sent to %{ recipient }', { recipient: response[0] }),
-          status: 'success'
-        })
-      } catch (error) {
-        console.error(error)
-        showErrorMessage({
-          title: $gettext('An error occurred'),
-          desc: $gettext('Email notification could not be sent'),
-          errors: [error]
-        })
-      }
+      // FIXME: cern code
+      // const response = await clientService.owncloudSdk.shares.notifyShare(props.share.id)
     }
 
     return {

packages/web-client/src/webdav/types.ts

@@ -1,4 +1,3 @@
-import { OwnCloudSdk } from '../types'
 import { CreateFolderFactory } from './createFolder'
 import { GetFileContentsFactory } from './getFileContents'
 import { GetFileInfoFactory } from './getFileInfo'
@@ -23,7 +22,6 @@ import { SetFavoriteFactory } from './setFavorite'
 import { ListFavoriteFilesFactory } from './listFavoriteFiles'
 
 export interface WebDavOptions {
-  sdk: OwnCloudSdk
   accessToken: Ref<string>
   baseUrl: string
   capabilities: Ref<Capabilities['capabilities']>

packages/web-pkg/src/composables/appDefaults/useAppFileHandling.ts

@@ -49,7 +49,7 @@ export function useAppFileHandling({
     return clientService.webdav.revokeUrl(url)
   }
 
-  // TODO: support query parameters, possibly needs porting away from owncloud-sdk
+  // TODO: support query parameters
   const getFileContents = (
     fileContext: MaybeRef<FileContext>,
     options: { responseType?: 'arrayBuffer' | 'blob' | 'text' } & Record<string, any>

packages/web-pkg/src/services/client/client.ts

@@ -4,7 +4,6 @@ import { Auth, AuthParameters } from './auth'
 import axios, { AxiosInstance } from 'axios'
 import { v4 as uuidV4 } from 'uuid'
 import { WebDAV } from '@ownclouders/web-client/src/webdav'
-import { OwnCloudSdk } from '@ownclouders/web-client/src/types'
 import { Language } from 'vue3-gettext'
 import { FetchEventSourceInit } from '@microsoft/fetch-event-source'
 import { sse } from '@ownclouders/web-client/src/sse'
@@ -69,7 +68,6 @@ export class ClientService {
   private ocUserContextClient: OcClient
   private ocPublicLinkContextClient: OcClient
 
-  private owncloudSdkClient: OwnCloudSdk
   private webdavClient: WebDAV
 
   constructor(options: ClientServiceOptions) {
@@ -162,14 +160,6 @@ export class ClientService {
     )
   }
 
-  public get owncloudSdk(): OwnCloudSdk {
-    return this.owncloudSdkClient
-  }
-
-  public set owncloudSdk(owncloudSdk: OwnCloudSdk) {
-    this.owncloudSdkClient = owncloudSdk
-  }
-
   public get webdav(): WebDAV {
     return this.webdavClient
   }

packages/web-runtime/package.json

@@ -25,7 +25,6 @@
     "lodash-es": "^4.17.21",
     "luxon": "3.2.1",
     "oidc-client-ts": "^2.4.0",
-    "owncloud-sdk": "3.1.0-alpha.10",
     "p-queue": "^6.6.2",
     "pinia": "2.1.7",
     "portal-vue": "3.0.0",

packages/web-runtime/src/container/bootstrap.ts

@@ -3,7 +3,6 @@ import { buildApplication, NextApplication } from './application'
 import { RouteLocationRaw, Router, RouteRecordNormalized } from 'vue-router'
 import { App, computed, watch } from 'vue'
 import { loadTheme } from '../helpers/theme'
-import OwnCloud from 'owncloud-sdk'
 import { createGettext, GetTextOptions, Language } from 'vue3-gettext'
 import { getBackendVersion, getWebVersion } from './versions'
 import {
@@ -379,7 +378,7 @@ export const announceAdditionalTranslations = ({
 }
 
 /**
- * announce clientService and owncloud SDK and inject it into vue
+ * announce clientService and inject it into vue
  *
  * @param vue
  * @param configStore
@@ -397,19 +396,14 @@ export const announceClientService = ({
   authStore: AuthStore
   capabilityStore: CapabilityStore
 }): void => {
-  const sdk = new OwnCloud()
-  sdk.init({ baseUrl: configStore.serverUrl })
   const clientService = new ClientService({
     configStore,
     language: app.config.globalProperties.$language,
     authStore,
     userStore
   })
-  app.config.globalProperties.$client = sdk
   app.config.globalProperties.$clientService = clientService
-  app.config.globalProperties.$clientService.owncloudSdk = sdk
   app.config.globalProperties.$clientService.webdav = webdav({
-    sdk,
     accessToken: computed(() => authStore.accessToken),
     baseUrl: configStore.serverUrl,
     capabilities: computed(() => capabilityStore.capabilities),
@@ -418,7 +412,6 @@ export const announceClientService = ({
     user: computed(() => userStore.user)
   })
 
-  app.provide('$client', sdk)
   app.provide('$clientService', clientService)
 }
 

packages/web-runtime/src/services/auth/userManager.ts

@@ -164,8 +164,6 @@ export class UserManager extends OidcUserManager {
         return
       }
 
-      this.initializeOwnCloudSdk(accessToken)
-
       if (this.capabilityStore.supportSSE) {
         ;(this.clientService.sseAuthenticated as SSEAdapter).updateAccessToken(accessToken)
       }
@@ -179,27 +177,6 @@ export class UserManager extends OidcUserManager {
     return this.updateAccessTokenPromise
   }
 
-  private initializeOwnCloudSdk(accessToken: string): void {
-    const options: Record<string, unknown> = {
-      baseUrl: this.configStore.serverUrl,
-      auth: {
-        bearer: accessToken
-      },
-      headers: {
-        'Accept-Language': this.language.current
-      }
-    }
-    if (this.userStore.user) {
-      options.userInfo = {
-        id: this.userStore.user.onPremisesSamAccountName,
-        'display-name': this.userStore.user.displayName,
-        email: this.userStore.user.mail
-      }
-    }
-
-    this.clientService.owncloudSdk.init(options)
-  }
-
   private async fetchUserInfo(accessToken: string): Promise<void> {
     await this.fetchCapabilities()
 
@@ -222,7 +199,6 @@ export class UserManager extends OidcUserManager {
         language: this.language,
         languageSetting: graphUser.data.preferredLanguage
       })
-      this.initializeOwnCloudSdk(accessToken)
     }
   }
 

packages/web-test-helpers/src/mocks/defaultComponentMocks.ts

@@ -8,7 +8,6 @@ import {
   UppyService
 } from '../../../web-pkg/src/'
 import { Router, RouteLocationNormalizedLoaded, RouteLocationRaw } from 'vue-router'
-import { OwnCloudSdk } from '../../../web-client/src/types'
 import { ref } from 'vue'
 
 export interface ComponentMocksOptions {
@@ -28,7 +27,6 @@ export const defaultComponentMocks = ({ currentRoute = undefined }: ComponentMoc
     $route,
     $clientService: mockDeep<ClientService>(),
     $previewService: mockDeep<PreviewService>(),
-    $client: mockDeep<OwnCloudSdk>(),
     $uppyService: mockDeep<UppyService>(),
     $loadingService: mock<LoadingService>({
       addTask: (callback) => {

tests/unit/config/vitest.config.ts

@@ -39,7 +39,6 @@ export default defineConfig({
     ],
     alias: {
       'vue-inline-svg': `${root}/tests/unit/stubs/empty.ts`,
-      'owncloud-sdk': `${root}/tests/unit/stubs/empty.ts`,
       webfontloader: `${root}/tests/unit/stubs/webfontloader.ts`
     },
     coverage: {

vite.config.ts

@@ -175,10 +175,10 @@ export default defineConfig(({ mode, command }) => {
           crypto: join(projectRootDir, 'polyfills/crypto.js'),
           buffer: 'rollup-plugin-node-polyfills/polyfills/buffer-es6',
           path: 'rollup-plugin-node-polyfills/polyfills/path',
+          util: 'rollup-plugin-node-polyfills/polyfills/util',
 
-          // owncloud-sdk // sax
+          // xml-js
           stream: 'rollup-plugin-node-polyfills/polyfills/stream',
-          util: 'rollup-plugin-node-polyfills/polyfills/util',
           string_decoder: 'rollup-plugin-node-polyfills/polyfills/string-decoder',
           process: 'rollup-plugin-node-polyfills/polyfills/process-es6',
           events: 'rollup-plugin-node-polyfills/polyfills/events'