feat: make full text search default #10626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
make-full-text-search-default
branch
from
098ba79 to
a0d5ccd
Compare
kulmann
requested changes
Mar 18, 2024
AlexAndBear
reviewed
Mar 18, 2024
| const fullTextParam = useRouteQuery('q_fullText') | ||
| const titleOnlyParam = useRouteQuery('q_titleOnly') | ||
|
|
||
| const fullTextSearchEnabled = computed(() => capabilityStore.searchContent?.enabled) |
There was a problem hiding this comment.
Why not using storeToRefs for that ?
There was a problem hiding this comment.
Because it's nested in the capabilities, meaning even if we'd use storeToRefs, we would still need to further narrow it down via a computed.
JammingBen
force-pushed
the
make-full-text-search-default
branch
3 times, most recently
from
c1b28de to
f9c97ca
Compare
|
Okay, now it searches for I decided to remove the generic query building we had before because it didn't really allow edge cases like we have here. |
Enables full text search as default if the server supports it.
JammingBen
force-pushed
the
make-full-text-search-default
branch
from
f9c97ca to
bc052dd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables full text search as default if the server supports it.
Related Issue
Types of changes