Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove usage of sdk for file version urls #10607

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Mar 14, 2024

Description

Removes the usage of the ownCloud SDK for file versions URLs since it's deprecated and we want to get rid of it. This could be achieved quite simple as nearly all the logic we had in useDownloadFile is already present in getFileUrl of our webdav implementation.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Mar 14, 2024
Copy link

update-docs bot commented Mar 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the remove-files-versions-sdk-involvement branch 5 times, most recently from c262f2c to ddd45af Compare March 14, 2024 11:36
Removes the usage of the ownCloud SDK for file versions URLs since it's deprecated and we want to get rid of it.
@JammingBen JammingBen force-pushed the remove-files-versions-sdk-involvement branch from ddd45af to f989302 Compare March 14, 2024 11:41
@JammingBen JammingBen marked this pull request as ready for review March 14, 2024 12:20
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@JammingBen JammingBen merged commit de7f209 into master Mar 15, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-files-versions-sdk-involvement branch March 15, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants