Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSE events for deleted (trashed) and restored files and folders #10586

Merged
merged 10 commits into from
Mar 15, 2024
Merged

SSE events for deleted (trashed) and restored files and folders #10586

merged 10 commits into from
Mar 15, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 12, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Mar 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title WIP SSE events for deleted (trashed) and restored Mar 12, 2024
@AlexAndBear AlexAndBear changed the title SSE events for deleted (trashed) and restored SSE events for deleted (trashed) and restored files and folders Mar 12, 2024
@AlexAndBear AlexAndBear marked this pull request as ready for review March 12, 2024 14:12
@AlexAndBear AlexAndBear requested a review from kulmann March 14, 2024 20:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
15.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kulmann
kulmann approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kulmann kulmann merged commit ad5e668 into master Mar 15, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the trash-sse branch March 15, 2024 07:27
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Implement Event "Resource Deleted"
2 participants
@AlexAndBear @kulmann