[test-only]check that image is open #10565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
don't merge please before fixing owncloud/ocis#8602 |
kulmann
reviewed
Mar 8, 2024
SagarGi
reviewed
Mar 12, 2024
18 tasks
ScharfViktor
force-pushed
the
checkThatImageIsOpen
branch
from
a7b2e4d to
5bfde0b
Compare
|
saw-jan
approved these changes
Mar 27, 2024
nabim777
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related owncloud/ocis#8602
we had test for this bug but unfortunately the test didn't expect an error
the image viewer was open, but the image did not appear
I'm wait locators now
we can check the response, but sometimes that doesn't give us a 100% guarantee that everything works. Example, openning broken pdf file:
for txt or md files we can check content(ctr+c and evaluate clickboard) but it dificult when user viewer