Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space emojis #10546

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Space emojis #10546

merged 6 commits into from
Mar 12, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 5, 2024 •
edited
Loading

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Mar 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review March 6, 2024 14:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
59.6% Coverage on New Code
10.5% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear requested a review from kulmann March 11, 2024 15:13
kulmann
kulmann approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome feature, well done! 🥇

@AlexAndBear AlexAndBear merged commit 02b279c into master Mar 12, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the space-emojis branch March 12, 2024 08:46
@kulmann kulmann mentioned this pull request Mar 22, 2024
Closed
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-schwarz felix-schwarz felix-schwarz left review comments

@TheOneRing TheOneRing TheOneRing left review comments

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Option: Use Emojis as Space Images
5 participants
@AlexAndBear @TheOneRing @felix-schwarz @kulmann @JammingBen