Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] backport acceptance test code changes from #10392 #10521

Merged

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Feb 28, 2024

This PR backports acceptance test changes from #10392
Part of #10457

Copy link

update-docs bot commented Feb 28, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@S-Panta S-Panta changed the title backporting from master [tests-only][full-ci]backporting from master Feb 28, 2024
@S-Panta S-Panta force-pushed the backport-from-master-use-sharing-for-share-listings branch from 6757508 to 6ceb95e Compare February 28, 2024 05:54
@S-Panta S-Panta self-assigned this Feb 28, 2024
@S-Panta S-Panta changed the title [tests-only][full-ci]backporting from master [tests-only][full-ci] backport-from-master-use-sharing-for-share-listings Feb 28, 2024
@S-Panta S-Panta marked this pull request as ready for review February 29, 2024 04:24
@saw-jan
Copy link
Member

saw-jan commented Mar 4, 2024

After #10504

@saw-jan
Copy link
Member

saw-jan commented Mar 4, 2024

since stable-8 will not have sharingNG implemented, let's keep the resharing tests in stable-8.0. But we can delete acceptance resharing tests

@saw-jan saw-jan force-pushed the backport-from-master-use-sharing-for-share-listings branch from 6ceb95e to 46302e1 Compare March 4, 2024 08:54
@saw-jan saw-jan changed the title [tests-only][full-ci] backport-from-master-use-sharing-for-share-listings [tests-only][full-ci] backport acceptance test code changes from #10392 Mar 4, 2024
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan requested a review from ScharfViktor March 4, 2024 09:17
ScharfViktor
ScharfViktor approved these changes Mar 4, 2024
@saw-jan
Copy link
Member

saw-jan commented Mar 4, 2024

#10392 seems that wrong link

I only copied the acceptance test changes of that PR (no src and no e2e - new feature)

@saw-jan saw-jan merged commit 40018f2 into stable-8.0 Mar 4, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport-from-master-use-sharing-for-share-listings branch March 4, 2024 10:25
@ScharfViktor
Copy link
Contributor

I only copied the acceptance test changes of that PR (no src and no e2e - new feature)

yes, I was wrong. sorry. I deleted my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants