Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epub reader dark theme support #10462

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

}

const LIGHT_THEME_CONFIG = {
html: { background: 'white' }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a placeholder, we can update the theme to our own needs later.
but could also kick that.

FYI @kulmann

@AlexAndBear AlexAndBear requested a review from kulmann February 9, 2024 11:07
@AlexAndBear AlexAndBear force-pushed the epub-reader-dark-theme-supprt branch from 9776795 to 594400e Compare February 9, 2024 11:07
Copy link

update-docs bot commented Feb 9, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Feb 9, 2024

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@AlexAndBear AlexAndBear enabled auto-merge (squash) February 9, 2024 11:24
@AlexAndBear AlexAndBear merged commit 243a16e into master Feb 9, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the epub-reader-dark-theme-supprt branch February 9, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants