Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom component extension type & extension preferences #10443

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Custom component extension type & extension preferences #10443

merged 12 commits into from
Apr 3, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Feb 5, 2024 •
edited
Loading

Description

  • custom component extension type, as a followup concept for vue-portal (we'll remove vue-portal some time in the future)
  • extension points concept, including the global progress bar as first extension point. Will add more extension points in a followup (trying to get rid of the scopes property on extensions).
  • generic extension user preferences, depending on registered extension points

Related Issue

Motivation and Context

Further mature the extension system framework.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • move loader app away from this branch, into a different repo
  • write unit tests for core concepts
  • clean up probably

@update-docs Update Docs
Copy link

update-docs bot commented Feb 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the loader-extension branch 3 times, most recently from a9960ab to 8a93f99 Compare February 8, 2024 12:27
@dschmidt dschmidt mentioned this pull request Feb 13, 2024
Closed
@kulmann kulmann force-pushed the loader-extension branch 4 times, most recently from 62fdf37 to bd1da34 Compare February 19, 2024 15:13
@kulmann kulmann marked this pull request as ready for review February 19, 2024 15:13
@kulmann kulmann self-assigned this Feb 20, 2024
dschmidt
dschmidt approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ❤️ ❤️ ❤️ this

docs/extension-system/extension-types/custom-components.md Outdated Show resolved Hide resolved
docs/extension-system/extension-types/custom-components.md Outdated Show resolved Hide resolved
docs/extension-system/extension-types/custom-components.md Outdated Show resolved Hide resolved
docs/extension-system/extension-types/custom-components.md Outdated Show resolved Hide resolved
packages/web-pkg/src/composables/piniaStores/extensionRegistry/extensionPreferences.ts Outdated Show resolved Hide resolved
packages/web-pkg/src/composables/piniaStores/extensionRegistry/extensionRegistry.ts Outdated Show resolved Hide resolved
packages/web-pkg/src/composables/piniaStores/extensionRegistry/types.ts Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Account/ExtensionPreference.vue Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
24 New issues

Measures
0 Security Hotspots
77.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann force-pushed the loader-extension branch from 7c5aab0 to a5c8b1e Compare March 4, 2024 14:11
@kulmann kulmann force-pushed the loader-extension branch from cb6900b to 42bfaf8 Compare April 2, 2024 12:59
@kulmann kulmann force-pushed the loader-extension branch from 433a726 to 6b72b84 Compare April 2, 2024 14:24
@kulmann kulmann requested a review from JammingBen April 3, 2024 09:37
JammingBen
JammingBen approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! 🚀

@kulmann kulmann enabled auto-merge (squash) April 3, 2024 11:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann merged commit b1be16c into master Apr 3, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the loader-extension branch April 3, 2024 12:33
ownclouders pushed a commit that referenced this pull request Apr 3, 2024
@kulmann
Custom component extension type & extension preferences (#10443)
3da0aa9 
feat: extension points, custom components, preferences
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extension point for replacing visuals of top loading indicator
3 participants
@kulmann @dschmidt @JammingBen