Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: vitest follow up #10419

Merged
merged 4 commits into from
Jan 30, 2024
Merged

test: vitest follow up #10419

merged 4 commits into from
Jan 30, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 29, 2024

Description

Switches to the happy-dom environment for better performance and removes jest-axe as we currently don't need a11y tests. The few tests where we actually need jsdom as environment we can simply use // @vitest-environment jsdom as annotation.

Also unskips some unit tests and has a few small improvements.

Follow-up after #10412

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 29, 2024
Copy link

update-docs bot commented Jan 29, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen changed the title Vitest follow up test: vitest follow up Jan 29, 2024
@JammingBen JammingBen marked this pull request as ready for review January 29, 2024 17:00
@delete-merged-branch delete-merged-branch bot deleted the branch master January 29, 2024 21:43
@JammingBen JammingBen changed the base branch from vitest to master January 30, 2024 06:28
Copy link

@JammingBen JammingBen merged commit d97c4d4 into master Jan 30, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the vitest-follow-up branch January 30, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants