Fix keyboard nav reactivity broken after delete items in admin settings #10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
commented
Jan 29, 2024
AlexAndBear
force-pushed
the
issues/10186
branch
2 times, most recently
from
643b6a7 to
fc343ad
Compare
AlexAndBear
force-pushed
the
issues/10186
branch
2 times, most recently
from
a1139ba to
97481c7
Compare
AlexAndBear
changed the title
dschmidt
approved these changes
Feb 5, 2024
packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/tests/unit/views/__snapshots__/Users.spec.ts.snap
Outdated
Show resolved
Hide resolved
|
AlexAndBear
force-pushed
the
issues/10186
branch
2 times, most recently
from
37b6387 to
1cf3cdd
Compare
kulmann
approved these changes
Mar 5, 2024
packages/web-app-admin-settings/src/composables/stores/groupSettings.ts
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/composables/stores/spaceSettings.ts
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/composables/stores/userSettings.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedikt Kulmann <[email protected]>
Co-authored-by: Benedikt Kulmann <[email protected]>
Co-authored-by: Benedikt Kulmann <[email protected]>
AlexAndBear
force-pushed
the
issues/10186
branch
from
b7d2d9b to
e302444
Compare
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed a bug where keyboard navigation stopped working after deleting a resource in the admin settings app.
We also fixed a bug where initial keyboard navigation didn't work, when no resource was selected.
This has been archived to add respective stores of the available user, space, group resources. Due to this change decluttering was also possible:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: