Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThemeSwitcher refactoring followup #10342

Merged
merged 10 commits into from
Jan 18, 2024
Merged

ThemeSwitcher refactoring followup #10342

merged 10 commits into from
Jan 18, 2024

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jan 16, 2024 •
edited
Loading

Description

See #10181

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@update-docs Update Docs
Copy link

update-docs bot commented Jan 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review January 16, 2024 12:25
@lookacat lookacat enabled auto-merge (squash) January 16, 2024 13:32
@JammingBen JammingBen force-pushed the theme-switcher-refactor-followup branch from 742f573 to 02b561c Compare January 16, 2024 15:24
@JammingBen JammingBen force-pushed the theme-switcher-refactor-followup branch from 02b561c to ffc01bb Compare January 16, 2024 15:26
@lookacat lookacat requested a review from AlexAndBear January 18, 2024 09:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
69.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lookacat lookacat merged commit 4839153 into master Jan 18, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the theme-switcher-refactor-followup branch January 18, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @AlexAndBear @JammingBen