[test-only]e2e test. create link with role #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ScharfViktor
force-pushed
the
createLinkWithRole
branch
from
7130c3c to
05a1307
Compare
|
saw-jan
approved these changes
Jan 16, 2024
S-Panta
pushed a commit
that referenced
this pull request
Feb 27, 2024
* create link with role * fix * fix language test
saw-jan
pushed a commit
that referenced
this pull request
Mar 4, 2024
* create link with role * fix * fix language test
saw-jan
pushed a commit
that referenced
this pull request
Mar 4, 2024
* create link with role * fix * fix language test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the ability to create a public link with the role added immediately at the time of creation
if we create public link with
Invited peoplerole - password is not required so I check messagePassword cannot be set for internal linksI would add Given step for creating link but want to do it when we switch to sharing NG