-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate design system docs to Vue 3 #10243
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
f254fcb
to
a338c3d
Compare
d4877a0
to
7f4c595
Compare
e2d5a32
to
d1badec
Compare
@JammingBen PR is ready for review. Let me pls know how do you want to handle changelog here. Also, with @kulmann we agreed to do tests in separate PR to quickly move on with dependency warnings but sonarcloud fails here due to insufficient coverage of new changes... let me pls know how do you want to handle this as well. I will look into the other sonarcloud issues in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off: awesome stuff, really great to finally have the ODS running again! 🥳
Let me pls know how do you want to handle changelog here.
I'd say this is a bugfix inside the design system's changelog folder, since building the ODS was basically broken before.
Also, with @kulmann we agreed to do tests in separate PR to quickly move on with dependency warnings but sonarcloud fails here due to insufficient coverage of new changes... let me pls know how do you want to handle this as well.
SonarCloud reports weird things sometimes (actually quite often), so it's not a blocker for our PRs in general. You can fix valid reports in a follow-up as well IMO.
I see that some unit tests for the docs are failing. I have no problem if you remove them to be honest, I don't really see the point in unit testing doc pages.
2 issues I still have when testing the build on my local machine:
- When running
pnpm build:docs
I get errors reporting a missingmini-css-extract-plugin
plugin (see annotation down below). - When running
pnpm start
I get some sass errors reporting undefined variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More or less nitpicks but I basically agree with everything that Jannik already said.
Additionally I would like to request that we have at least one basic e2e test, that makes sure the documentation app boots, we can navigate towards the documentation of a component and check it's rendered and functional (e.g. go to OcRadio and change the state)
That would give us much more confidence when accepting renovatebot PRs
Great work already!
packages/design-system/src/components/OcSearchBar/OcSearchBar.vue
Outdated
Show resolved
Hide resolved
This is basically happening because there are same tokens defined for docs and the design system and the build just drops the docs ones... I'll see if the overwrite can be prevented. |
Yep, this is planned for the follow up PR. |
66da328
to
fe83bdf
Compare
All issues resolved - ready for second round @JammingBen @dschmidt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a little fix for the initial focus on modals (which was broken for some reason 🤷 ).
Also I noticed that the examples in the docs are empty (between a component's description and the code block). But I'd say let's merge this PR as a first step and iterate from here 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this as a first iteration, but I would really like integration in our CI pipeline for building the ODS docs and having basic e2e tests (the latter possibly as a third iteration)
* chore: upgrade vue styleguidist * Fix acorn issue * Downgrade vue in design-system * chore: move docs components together with the rest and migrate codemirror * refactor: conform to eslint rules * test: update snapshots and use test utils instead of vue constructor * refactor: conform to sonarcloud standards * fix: bring back minicss plugin, resolve tokens collisions and drop docs unit tests * fix: initial modal focus --------- Co-authored-by: Dominik Schmidt <[email protected]> Co-authored-by: Jannik Stehle <[email protected]>
Description
Related Issue
Motivation and Context
Make design system docs buildable again and update dependencies
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: