Replace pgettext with gettext #10225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
force-pushed
the
remove-pgettext
branch
from
23b5054 to
1e8c835
Compare
AlexAndBear
commented
Dec 20, 2023
packages/web-pkg/src/composables/actions/files/useFileActionsPaste.ts
Outdated
Show resolved
Hide resolved
kulmann
approved these changes
Dec 20, 2023
|
JammingBen
approved these changes
Dec 20, 2023
ownclouders
pushed a commit
that referenced
this pull request
Dec 20, 2023
AlexAndBear
added a commit
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We removed pgettext, since we merge all translations.json files into one global json file for vue-gettext it is not possible to have two translation types, one created via $gettext (e.G
{"Copy": "Kopieren"}) and one via $pgettext (e.G{"Copy":{"Action in the files list row to initiate copying resources":"Kopieren"}}in one json file as the keys are identical.So those compete against each other and one get lost, and lead to a non translated string
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: