Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] test: add e2e test for directly opening project space through url #10202

Merged
merged 4 commits into from
Dec 19, 2023
Merged

[tests-only] test: add e2e test for directly opening project space through url #10202

merged 4 commits into from
Dec 19, 2023

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Dec 18, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@SwikritiT SwikritiT self-assigned this Dec 18, 2023
@SwikritiT SwikritiT force-pushed the tests/url-stability-open-on-web-space-root branch 2 times, most recently from 73aff84 to f38b904 Compare December 18, 2023 10:47
@SwikritiT SwikritiT marked this pull request as ready for review December 18, 2023 10:48
@SwikritiT SwikritiT force-pushed the tests/url-stability-open-on-web-space-root branch from f38b904 to 4268a5a Compare December 18, 2023 10:55
@SwikritiT SwikritiT force-pushed the tests/url-stability-open-on-web-space-root branch from 63c7ff9 to 2018975 Compare December 19, 2023 06:08
@SwikritiT SwikritiT force-pushed the tests/url-stability-open-on-web-space-root branch from 5999c74 to 1c5577f Compare December 19, 2023 07:25
@SwikritiT SwikritiT requested a review from saw-jan December 19, 2023 07:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ScharfViktor ScharfViktor merged commit 65a0278 into stable-8.0 Dec 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the tests/url-stability-open-on-web-space-root branch December 19, 2023 08:30
@SwikritiT SwikritiT mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwikritiT @saw-jan @ScharfViktor