Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create dedicated action for creating groups #10197

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

JammingBen
Copy link
Contributor

Description

Moved all relevant code parts to the CreateGroupModal component in the course of this, instead of having it spread all over the place.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 15, 2023
Copy link

update-docs bot commented Dec 15, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen changed the base branch from master to stable-8.0 December 18, 2023 08:29
Removes the password logic from the modal implementation and uses a custom component instead.
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
69.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JammingBen JammingBen requested a review from dschmidt December 18, 2023 18:23
@kulmann kulmann merged commit c0a5312 into stable-8.0 Dec 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the create-group-action branch December 19, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants