Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors not shown while creating link fails #10187

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix errors not shown while creating link fails #10187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b438c3
Fix errors not shown while creating link fails
AlexAndBear Dec 15, 2023
0fc4c9d
Enhance changelog item
AlexAndBear Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-create-link-modal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ When creating a link while passwords are enfoced, Web will now display a modal t
https://github.com/owncloud/web/pull/10104
https://github.com/owncloud/web/pull/10145
https://github.com/owncloud/web/pull/10159
https://github.com/owncloud/web/pull/10187
https://github.com/owncloud/web/issues/10157
4 changes: 2 additions & 2 deletions packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ export const useFileActionsCreateLink = ({
}

const failed = result.filter(({ status }) => status === 'rejected')
if (failed.length && showMessages) {
if (failed.length) {
store.dispatch('showErrorMessage', {
errors: (failed as PromiseRejectedResult[]).map(({ reason }) => new Error(reason)),
errors: (failed as PromiseRejectedResult[]).map(({ reason }) => reason),
title: $ngettext('Failed to create link', 'Failed to create links', failed.length)
})
}
Expand Down