-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show file extensions in AppTopBar and Search if turned off via setting #10176
Don't show file extensions in AppTopBar and Search if turned off via setting #10176
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have unit tests for the two components? Could you add a unit test about the view option being respected?
changelog/unreleased/bugfix-turned-off-file-extensions-had-no-effect
Outdated
Show resolved
Hide resolved
changelog/unreleased/bugfix-turned-off-file-extensions-had-no-effect
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedikt Kulmann <[email protected]>
Co-authored-by: Benedikt Kulmann <[email protected]>
changelog/unreleased/bugfix-turned-off-file-extensions-had-no-effect
Outdated
Show resolved
Hide resolved
false | ||
) | ||
|
||
expect(wrapper.html()).toMatchSnapshot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check instead that the displayed file name matches test
instead of test.txt
? You're testing one very specific detail, I'd like to avoid to throw a snapshot test at that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole tests are snapshot tests, I don't wanted to interfere here,
if you want me to change that, please say yes and I will follow, my team lead 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm ok, then do it with the snapshot test. I'll make it part of the unit test improvement initiative 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be sick on the unit test improvement initiative
:(
packages/web-pkg/tests/unit/components/Search/ResourcePreview.spec.ts
Outdated
Show resolved
Hide resolved
…effect Co-authored-by: Benedikt Kulmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: