Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show file extensions in AppTopBar and Search if turned off via setting #10176

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

Copy link

update-docs bot commented Dec 14, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have unit tests for the two components? Could you add a unit test about the view option being respected?

@AlexAndBear AlexAndBear requested a review from kulmann December 15, 2023 08:38
false
)

expect(wrapper.html()).toMatchSnapshot()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check instead that the displayed file name matches test instead of test.txt? You're testing one very specific detail, I'd like to avoid to throw a snapshot test at that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole tests are snapshot tests, I don't wanted to interfere here,
if you want me to change that, please say yes and I will follow, my team lead 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm ok, then do it with the snapshot test. I'll make it part of the unit test improvement initiative 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be sick on the unit test improvement initiative :(

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Dec 15, 2023

@AlexAndBear AlexAndBear enabled auto-merge (squash) December 15, 2023 11:18
@AlexAndBear AlexAndBear merged commit 350d3db into master Dec 15, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-file-extensions-shown-even-if-settings-is-off branch December 15, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants