Update theming docs after #9698 #10151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
force-pushed
the
docs/update-theming
branch
from
86a297a to
89f3109
Compare
kulmann
reviewed
Dec 12, 2023
docs/theming/_index.md
Outdated
|
|
||
| The `common` section provides a set of information that is designed to be available for all clients. It gets merged "down" to the final themes and aims to reduce duplication, but can be overwritten by more specific information inside both the clients' defaults and actual themes. | ||
|
|
||
| The structure of a valid `comon` section is outlined below: |
There was a problem hiding this comment.
Suggested change
| The structure of a valid `comon` section is outlined below: | |
| The structure of a valid `common` section is outlined below: |
docs/theming/_index.md
Outdated
| } | ||
| ``` | ||
|
|
||
| - `name` specifies the publicly visible name for this oCIS instance |
There was a problem hiding this comment.
My feeling is that the repetition of for this oCIS instance is a bit too much.
…of custom props from ODS
|
ownclouders
pushed a commit
that referenced
this pull request
Dec 14, 2023
Update theming docs after #9698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue