fix: skip reusing old token in embed mode with delegated auth #10113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
added
Status:In-Progress
Category:Defect
This comment was marked as outdated.
This comment was marked as outdated.
|
I have also added a few logs into the code so that it is easier to debug the embed mode. |
LukasHirt
force-pushed
the
fix/delegate-auth-error
branch
from
63fcd28 to
2494d73
Compare
LukasHirt
added
Status:Needs-Review
kulmann
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
I added two commits myself to fast-track this...
1: no extra changelog item needed as the delegated authentication was never publicly released. I just added the PR url to an existing changelog item
2: I reduced the log level of your new log messages to debug to not spam the browser console.
Otherwise perfect, thanks for jumping on this quickly 👍
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* fix: skip reusing old token in embed mode with delegated auth --------- Co-authored-by: Benedikt Kulmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Web is included in an iframe in embed mode with delegated authentication, skip reusing the old token. The parent application is responsible for handling the token and we do not really care about reloading there which the reuse seems to be intended to handle. If the old token is reused, it can lead to an error when fetching user with expired token. That will then lead to a redirect to access denied page once the delegated access_token is received.
Motivation and Context
Fixing a bug which leads to access denied page.
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: