Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin settings fix mark problems, remove memberOf from list users query #10090

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Admin settings fix mark problems, remove memberOf from list users query #10090

merged 3 commits into from
Nov 29, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 29, 2023 •
edited
Loading

Description

Only mark relevant columns like displayName while search term is applied
Mark new entities while being added and search term is applied

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Nov 29, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear mentioned this pull request Nov 29, 2023
Closed
@AlexAndBear AlexAndBear force-pushed the admin-settings-fix-serarch-markers branch from 11e083c to a4de73d Compare November 29, 2023 14:43
@AlexAndBear AlexAndBear changed the title Admin settings fix mark problems Admin settings fix mark problems, remove memberOf from list users query Nov 29, 2023
kulmann
kulmann approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.4% 77.4% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 5b93e5e into master Nov 29, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the admin-settings-fix-serarch-markers branch November 29, 2023 15:40
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Admin settings fix mark problems, remove memberOf from list users que…
423df4c 
…ry (#10090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @kulmann