Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No scrolling to just created folder #7600

Closed
elizavetaRa opened this issue Sep 7, 2022 · 2 comments · Fixed by #9145
Closed

No scrolling to just created folder #7600

elizavetaRa opened this issue Sep 7, 2022 · 2 comments · Fixed by #9145
Labels
Early-Adopter:CERN Platform:Web

Comments

@elizavetaRa
Copy link
Member

elizavetaRa commented Sep 7, 2022 •
edited
Loading

Steps to reproduce

  1. Create a new folder in the repository with many folders and name it, so that it's name is outside of the view

Expected behaviour

The view should scroll to the created folder

Actual behaviour

  • There is no scrolling
  • Users get confused if the folder was actually created (from user feedback)
  • Users need to scroll manually and search for the folder
@elizavetaRa
Copy link
Member Author

elizavetaRa commented Sep 7, 2022 •
edited
Loading

Related to it: #7601
Our proposal is to enable scrollToResource on creation of the folders and set scrolling to the middle of the view (gdrive like). @tbsbdr opinion on usability? In my opinion, this way the resource it highlighted better than when it's placed in the very top/bottom of the list
Our implementation of this proposal: cernbox@460b98c
ragozina - Personal - CERNBox

@pascalwengerter
Copy link
Contributor

@elizavetaRa could you turn this into a (simple) bugfix PR to the upstream owncloud/web repo? Ideally you can even get rid of the filesListScrolling.js-mixin and inline the necessary 1-2 lines of JS

@pascalwengerter pascalwengerter mentioned this issue Jun 1, 2023
Merged
@dschmidt dschmidt mentioned this issue Jul 10, 2023
Closed
37 tasks
pascalwengerter added a commit to pascalwengerter/web that referenced this issue Jul 24, 2023
@pascalwengerter
Fix owncloud#7600 && owncloud#7601
5e09c8b
JammingBen pushed a commit that referenced this issue Jul 25, 2023
@pascalwengerter @dschmidt
Feature/7600 - Scroll to newly created folder (#9145)
6aabd53 
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <[email protected]>
saw-jan pushed a commit that referenced this issue Jul 27, 2023
@pascalwengerter @dschmidt @saw-jan
Feature/7600 - Scroll to newly created folder (#9145)
bb9a7fc 
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <[email protected]>
AlexAndBear pushed a commit that referenced this issue Aug 15, 2023
@pascalwengerter @dschmidt
Feature/7600 - Scroll to newly created folder (#9145)
1998e9e 
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <[email protected]>
@micbar micbar mentioned this issue Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this issue Dec 13, 2023
@pascalwengerter @dschmidt @AlexAndBear
Feature/7600 - Scroll to newly created folder (#9145)
4703acc 
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Early-Adopter:CERN Platform:Web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/7600 - Scroll to newly created folder pascalwengerter/web
3 participants
@elizavetaRa @pascalwengerter @tbsbdr