Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No share indicators inside share jail #6894

Closed
kulmann opened this issue May 6, 2022 · 2 comments
Closed

No share indicators inside share jail #6894

kulmann opened this issue May 6, 2022 · 2 comments
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented May 6, 2022

With the share jail being merged, navigating into a share (via shared with me view) doesn't show any share indicators anymore. Since we don't have re-sharing with oCIS and since anything that is inside a SharedResource view lives there because it was shared in the first place, might make sense to just not support share indicators in the SharedResource views.

Steps to reproduce

  1. As einstein, share a folder with marie
  2. As marie, accept the shared folder
  3. As marie, navigate into the shared folder

Expected behaviour

I guess showing share indicators doesn't make sense. If at all, I'd expect share indicators for re-shared files/folders, but we don't support re-sharing with oCIS, yet.

Actual behaviour

Well, no share indicators are being shown. Which makes sense to me, but need to be confirmed by @tbsbdr

Todo

As soon as we have re-sharing with ocis we want to have share indicators in the shared with me view.

@kulmann kulmann added Type:Bug Something isn't working Interaction:Question labels May 6, 2022
@kulmann kulmann added the Priority:p3-medium Normal priority label May 9, 2022
@kulmann
Copy link
Member Author

kulmann commented May 10, 2022

Discussed in a call with @tbsbdr that this is indeed the desired behaviour. Incoming shares should never result in a share indicator. As soon as we have re-shares in ocis we'll indicate these with the usual share indicators, but in the shared with me page.

@kulmann kulmann changed the title No share indicators inside share jail (needs concept / PM decision) No share indicators inside share jail May 10, 2022
@JammingBen
Copy link
Contributor

Closing this as we already have the expected behavior by now:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants