Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check closed issue No share indicators inside share jail still exist in expected-to-failure #4678

Closed
amrita-shrestha opened this issue Sep 27, 2022 · 3 comments
Assignees
Labels

Comments

@amrita-shrestha
Copy link
Contributor

No share indicators inside share jail issue has been closed but still their are some scenario under this issue.Check why there are scenario under No share indicators inside share jail closed issue

### [No share indicators inside share jail](https://github.com/owncloud/web/issues/6894)
- [webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:100](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersSharingIndicator/shareWithUsers.feature#L100)
- [webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:121](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersSharingIndicator/shareWithUsers.feature#L121)
- [webUISharingPublicManagement/publicLinkIndicator.feature:64](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkIndicator.feature#L64)
- [webUISharingPublicManagement/publicLinkIndicator.feature:81](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkIndicator.feature#L81)
- [webUISharingPublicManagement/publicLinkIndicator.feature:98](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkIndicator.feature#L98)
- [webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:61](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature#L61)
- [webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:80](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature#L80)
- [webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature#L42)
- [webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:80](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersSharingIndicator/shareWithUsers.feature#L80)

@SagarGi
Copy link
Member

SagarGi commented Oct 11, 2022

Findings:

For features:

webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:100
webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:121
webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:80
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:42
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:61
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:80

These tests tries to open Shares that is in root in oc10 web but in ocis no shares folder is there since there is a separate Shares jail for it which is why the tests is failing.

Also for features:

webUISharingPublicManagement/publicLinkIndicator.feature:64
webUISharingPublicManagement/publicLinkIndicator.feature:80
webUISharingPublicManagement/publicLinkIndicator.feature:98

These tests fails because when a user shares a folder to other in oc10(if Shares is not created by default) then the shared resources exist in the All files section of UI but in ocis it is not possible since it has dedicate place Shares jail for shared resources.

These tests can be skipped on ocis and can be added to implementation on playwright. @SwikritiT @amrita-shrestha ?

@SwikritiT
Copy link
Contributor

SwikritiT commented Oct 11, 2022

Findings:

For features:

webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:100
webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:121
webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:80
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:42
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:61
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:80

These tests tries to open Shares that is in root in oc10 web but in ocis no shares folder is there since there is a separate Shares jail for it which is why the tests is failing.

Also for features:

webUISharingPublicManagement/publicLinkIndicator.feature:64
webUISharingPublicManagement/publicLinkIndicator.feature:80
webUISharingPublicManagement/publicLinkIndicator.feature:98

These tests fails because when a user shares a folder to other in oc10(if Shares is not created by default) then the shared resources exist in the All files section of UI but in ocis it is not possible since it has dedicate place Shares jail for shared resources.

These tests can be skipped on ocis and can be added to implementation on playwright. @SwikritiT @amrita-shrestha ?

Yes skip them as there's never going to be Shares folder in Ocis in UI level but do add a comment n why the tests are skipped in ocis so that it's easier in future if someone happens to go through the tests again

@SagarGi
Copy link
Member

SagarGi commented Oct 12, 2022

Can be closed since this PR is merged owncloud/web#7766

@SagarGi SagarGi closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants