Icon for Draw files (.*odg)

[merttumer]

We recently made this pr: owncloud/richdocuments#456 which adds a support for opening .odg files with Collabora Online. But we noticed that there's no icon for the .odg files and it just displayed as regular files.

[pascalwengerter]

Hey @merttumer, thanks for the suggestion! As far as I know CERN (@elizavetaRa @diocas) are planning to add new fileType icons (and perhaps also one for draw documents) to our design system sometime soon, let's check back with them!

Relevant file is in https://github.com/owncloud/core/blob/master/core/img/filetypes/x-office-drawing.svg

[tbsbdr]

@elizavetaRa any news on that 👆 ?

[elizavetaRa]

@tbsbdr We added some icons here already and some more are planed to come soon. I will create a pr for this.
cernbox/owncloud-design-system@fbd99a2

[pascalwengerter]

@tbsbdr We added some icons here already and some more are planed to come soon. I will create a pr for this. cernbox/owncloud-design-system@fbd99a2

Yes please :) looking forward, and should be easily merged&published!

[pascalwengerter]

@merttumer could you check https://github.com/cernbox/owncloud-design-system/pull/222/files?short_path=96c0611#diff-96c0611a06530f1b881159642cf99d4ce92f33d212670b795e5e0548442bdde6 and see if it suits your needs? (Icon will be added in the CERN fork of the ownCloud design system first and then merged upstream, coming to the web codebase before the next release towards end of next week)

Also, what is the license situation with your icons? We've cleaned up our codebase and are a bit wary to not introduce any offenses again :)

[merttumer]

Unfortunately, .odg files are still displayed as black file icon

Oh, icon will be added later I see. I see no problem on my side with the icon. I will ask about the license situation :)

[pedropintosilva]

Hi there : ) thanks for the heads up @pascalwengerter , (@merttumer has asked me if I could take a look at this and try to help)
So I have checked @elizavetaRa 's patch and they look good ❤️

Generally speaking I do not see any blocker here. Nevertheless and if I might share bit of context:

I would say that for the specific ODG file type I'm afraid resource-type-graphic-fill.svg might be a bit misleading. Even though when working with ODG we have the cool feature of those connectors it is not only for diagrams and there are many other use cases where users/students create drawings or documents such as one page flyer or other promotional materials. Plus it can start to get a bit confusing if we have 3 icons referencing diagrams (resource-type-drawio-fill, resource-type-graphic-fill.svg, and this one)

I would propose to play around with the main elements present in the original mime-type icon while trying to fit it in the current design system : ) here is my quick attempt to do so:

resource-type-draw-fill.svg

What do you think?

[pascalwengerter]

Reopening since it hasn't landed in web yet, also would like to get a positive reply from @pedropintosilva before closing this

[pascalwengerter]

@pedropintosilva @elizavetaRa FYI :)

[pedropintosilva]

Seems good @pascalwengerter thanks !

[pascalwengerter]

Hey, thanks for getting back to me this quickly. My question was not about whether the issue can be closed (it can't, we'll need to update our design system first) but more about the license around using your SVG file :) could you clarify that in the issue (see my last question)? Best, Pascal

…

-----Original message----- From: Mert ***@***.***> Sent: Friday March 11th, 2022 13:35 To: owncloud/web ***@***.***> Cc: Pascal Wengerter ***@***.***>; Assign ***@***.***> Subject: Re: [owncloud/web] Icon for Draw files (.*odg) (Issue #6416) Unfortunately, .odg files are still displayed as black file icon — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: ***@***.***>