Image that is uploaded first, if opened first the picture is not displayed in the image media viewer in ocis backend

[SwikritiT]

The image that is uploaded first, if opened first the picture is not displayed in the image media viewer

Steps to reproduce

1. docker-compose pull

2. docker-compose up ocis selenium vnc

3. Access ocis through vnc

4. Log in to Einstein

5. upload testavatar.jpg first and then upload testavatar.png

6. Now open testavatar.jpg in a media viewer through the details panel. A blank white screen is shown instead of a picture.
   

7. Go to the next picture testavatar.png through the media viewer. It displays.

7. Now go back to the previous picture. White screen again but the name at the bottom is testavatar.png

8. Delete both of the pictures and repeat step 4
9. This time open testavatar.png first (i.e the image that was uploaded second) through details panel. It's displayed.

10. Switch to the next image. It is also displayed.

11. This issue does not exist for video formats or if only one picture is uploaded.

Expected behaviour

The image should be displayed no matter the order of upload.

Actual behaviour

As described above

[individual-it]

@SwikritiT please try to see if that works with an older version of web (as it works with the web that is compiled into ocis)
and with git bisect find the commit that caused it

[SwikritiT]

I think the problem with the media viewer arose from this owncloud/ocis#2739 PR in ocis. I couldn't track it down to a single commit because a lot of ocis commits didn't build properly and I had to skip them. Upon git bisect, it showed that one of these might be the first faulty commits.

b63b322b6f0abfd2cb4e6a7f3359b6517e56f723
c36e99895bbfd25b923455feb6b1c16f0f52e576
5a29959a0bfe26fa468101207c0343cd283f737f
de7620af98a2ec3fdd36bc90a83cd0597a3fb89b
5ec72daaeb512efbc83c62e13fc098f4f49ed5a0 

Surprisingly I couldn't reproduce the problem in the current master ocis. It can be reproduced in commits from this PR owncloud/ocis#2739 to this owncloud/ocis#2989

but after this commit, it cannot (so maybe it fixed it?) owncloud/ocis@0bfc1f0

I also tried to reproduce it with the previous version of the web and yes it can be reproduced if the ocis is between owncloud/ocis#2739 to this owncloud/ocis#2989 commit

[phil-davis]

Yes, the problem is not happening in CI any more when it points to the very latest oCIS commit id. So "something happened" in the last week or so that fixed it.