Skip to content

Commit

Permalink
Add changelog, linting, snapshots
Browse files Browse the repository at this point in the history
  • Loading branch information
lookacat committed Aug 24, 2022
1 parent 3d71e65 commit f7a4b67
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 11 deletions.
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-keyboard-not-working-spaces
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Paste action (keyboard) not working in project spaces

We've fixed a bug which caused the user to be unable to paste in project spaces.

https://github.com/owncloud/web/issues/7510
https://github.com/owncloud/web/pull/7514
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ export default defineComponent({
},
mounted() {
for(var elementId of this.keybindOnElementIds) {
for (const elementId of this.keybindOnElementIds) {
const element = document.getElementById(elementId)
if (element) {
element.addEventListener('keydown', this.handleShortcut, false)
}
}
document.addEventListener('keydown', this.handlePasteShortcut)
const fileListClickedEvent = bus.subscribe('app.files.list.clicked', this.resetSelectionCursor)
const fileListClickedMetaEvent = bus.subscribe(
'app.files.list.clicked.meta',
Expand All @@ -62,7 +62,7 @@ export default defineComponent({
bus.unsubscribe('app.files.list.clicked', fileListClickedEvent)
bus.unsubscribe('app.files.list.clicked.meta', fileListClickedMetaEvent)
bus.unsubscribe('app.files.list.clicked.shift', fileListClickedShiftEvent)
for(var elementId of this.keybindOnElementIds) {
for (const elementId of this.keybindOnElementIds) {
const element = document.getElementById(elementId)
if (element) {
element.removeEventListener('keydown', this.handleShortcut)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ exports[`Trashbin component when the view is not loading anymore when length of
<td class="oc-td oc-table-cell oc-table-cell-align-left oc-table-cell-align-middle oc-table-cell-width-shrink oc-table-data-cell oc-table-data-cell-select oc-pl-m "><span><input id="resource-table-select-file-id-1234" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l" value=""> <label for="resource-table-select-file-id-1234" class="oc-invisible-sr oc-cursor-pointer">Select folder</label></span></td>
<td class="oc-td oc-table-cell oc-table-cell-align-left oc-table-cell-align-middle oc-table-cell-width-expand oc-text-truncate oc-table-data-cell oc-table-data-cell-name">
<div class="resource-table-resource-wrapper resource-table-resource-wrapper-limit-max-width">
<div class="oc-resource oc-text-overflow"><span><span class="oc-icon oc-icon-l oc-icon-passive oc-resource-icon oc-resource-icon-file"><!----></span></span>
<div class="oc-resource-details oc-text-overflow"><span class="oc-text-overflow"><!----> <span data-test-resource-path="/file-path/1234" data-test-resource-name="file-path/file-name-1234" data-test-resource-type="folder" class="oc-resource-name"><span class="oc-text-truncate"><span class="oc-resource-basename">file-name-1234</span></span>
<div class="oc-resource oc-text-overflow"><span draggable="false"><span class="oc-icon oc-icon-l oc-icon-passive oc-resource-icon oc-resource-icon-file"><!----></span></span>
<div draggable="false" class="oc-resource-details oc-text-overflow"><span draggable="false" class="oc-text-overflow"><!----> <span data-test-resource-path="/file-path/1234" data-test-resource-name="file-path/file-name-1234" data-test-resource-type="folder" class="oc-resource-name" draggable="false"><span class="oc-text-truncate"><span class="oc-resource-basename">file-name-1234</span></span>
<!----></span></span>
<div class="oc-resource-indicators">
<router-link-stub to="[object Object]" class="parent-folder" style="cursor: pointer;"><span class="oc-icon oc-icon-s oc-icon-passive"><!----></span> <span class="text">file-path</span></router-link-stub>
Expand All @@ -38,8 +38,8 @@ exports[`Trashbin component when the view is not loading anymore when length of
<td class="oc-td oc-table-cell oc-table-cell-align-left oc-table-cell-align-middle oc-table-cell-width-shrink oc-table-data-cell oc-table-data-cell-select oc-pl-m "><span><input id="resource-table-select-file-id-5896" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l" value=""> <label for="resource-table-select-file-id-5896" class="oc-invisible-sr oc-cursor-pointer">Select folder</label></span></td>
<td class="oc-td oc-table-cell oc-table-cell-align-left oc-table-cell-align-middle oc-table-cell-width-expand oc-text-truncate oc-table-data-cell oc-table-data-cell-name">
<div class="resource-table-resource-wrapper resource-table-resource-wrapper-limit-max-width">
<div class="oc-resource oc-text-overflow"><span><span class="oc-icon oc-icon-l oc-icon-passive oc-resource-icon oc-resource-icon-file"><!----></span></span>
<div class="oc-resource-details oc-text-overflow"><span class="oc-text-overflow"><!----> <span data-test-resource-path="/file-path/5896" data-test-resource-name="file-path/file-name-5896" data-test-resource-type="folder" class="oc-resource-name"><span class="oc-text-truncate"><span class="oc-resource-basename">file-name-5896</span></span>
<div class="oc-resource oc-text-overflow"><span draggable="false"><span class="oc-icon oc-icon-l oc-icon-passive oc-resource-icon oc-resource-icon-file"><!----></span></span>
<div draggable="false" class="oc-resource-details oc-text-overflow"><span draggable="false" class="oc-text-overflow"><!----> <span data-test-resource-path="/file-path/5896" data-test-resource-name="file-path/file-name-5896" data-test-resource-type="folder" class="oc-resource-name" draggable="false"><span class="oc-text-truncate"><span class="oc-resource-basename">file-name-5896</span></span>
<!----></span></span>
<div class="oc-resource-indicators">
<router-link-stub to="[object Object]" class="parent-folder" style="cursor: pointer;"><span class="oc-icon oc-icon-s oc-icon-passive"><!----></span> <span class="text">file-path</span></router-link-stub>
Expand All @@ -58,8 +58,8 @@ exports[`Trashbin component when the view is not loading anymore when length of
<td class="oc-td oc-table-cell oc-table-cell-align-left oc-table-cell-align-middle oc-table-cell-width-shrink oc-table-data-cell oc-table-data-cell-select oc-pl-m "><span><input id="resource-table-select-file-id-9856" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l" value=""> <label for="resource-table-select-file-id-9856" class="oc-invisible-sr oc-cursor-pointer">Select folder</label></span></td>
<td class="oc-td oc-table-cell oc-table-cell-align-left oc-table-cell-align-middle oc-table-cell-width-expand oc-text-truncate oc-table-data-cell oc-table-data-cell-name">
<div class="resource-table-resource-wrapper resource-table-resource-wrapper-limit-max-width">
<div class="oc-resource oc-text-overflow"><span><span class="oc-icon oc-icon-l oc-icon-passive oc-resource-icon oc-resource-icon-file"><!----></span></span>
<div class="oc-resource-details oc-text-overflow"><span class="oc-text-overflow"><!----> <span data-test-resource-path="/file-path/9856" data-test-resource-name="file-path/file-name-9856" data-test-resource-type="folder" class="oc-resource-name"><span class="oc-text-truncate"><span class="oc-resource-basename">file-name-9856</span></span>
<div class="oc-resource oc-text-overflow"><span draggable="false"><span class="oc-icon oc-icon-l oc-icon-passive oc-resource-icon oc-resource-icon-file"><!----></span></span>
<div draggable="false" class="oc-resource-details oc-text-overflow"><span draggable="false" class="oc-text-overflow"><!----> <span data-test-resource-path="/file-path/9856" data-test-resource-name="file-path/file-name-9856" data-test-resource-type="folder" class="oc-resource-name" draggable="false"><span class="oc-text-truncate"><span class="oc-resource-basename">file-name-9856</span></span>
<!----></span></span>
<div class="oc-resource-indicators">
<router-link-stub to="[object Object]" class="parent-folder" style="cursor: pointer;"><span class="oc-icon oc-icon-s oc-icon-passive"><!----></span> <span class="text">file-path</span></router-link-stub>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`Spaces project view space image should show if given 1`] = `
<div class="space-overview oc-flex">
<keyboard-actions-stub paginatedresources="" keybindonelementid="files-view"></keyboard-actions-stub>
<keyboard-actions-stub paginatedresources="" keybindonelementids="files,web-nav-sidebar"></keyboard-actions-stub>
<files-view-wrapper-stub>
<app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
<div>
Expand Down Expand Up @@ -41,7 +41,7 @@ exports[`Spaces project view space image should show if given 1`] = `

exports[`Spaces project view space readme should show if given 1`] = `
<div class="space-overview oc-flex">
<keyboard-actions-stub paginatedresources="" keybindonelementid="files-view"></keyboard-actions-stub>
<keyboard-actions-stub paginatedresources="" keybindonelementids="files,web-nav-sidebar"></keyboard-actions-stub>
<files-view-wrapper-stub>
<app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
<div>
Expand Down

0 comments on commit f7a4b67

Please sign in to comment.