Merge pull request #7532 from owncloud/fixUploadNightlyFailure

[tests-only][full-ci]Refactor code for upload nightly fail
owncloud · Aug 26, 2022 · f254f78 · f254f78
2 parents 1a54195 + 013b8e3
commit f254f78
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/tests/acceptance/pageObjects/personalPage.js b/tests/acceptance/pageObjects/personalPage.js
@@ -244,6 +244,7 @@ module.exports = {
         .waitForElementNotPresent('@dialog')
         .waitForAjaxCallsToStartAndFinish()
         .waitForElementVisible('@fileUploadStatus')
+        .closeFileFolderUploadProgress()
       return this
     },
     checkForButtonDisabled: function () {

diff --git a/tests/acceptance/stepDefinitions/filesContext.js b/tests/acceptance/stepDefinitions/filesContext.js
@@ -213,13 +213,16 @@ When('the user uploads a created file {string} using the webUI', function (eleme
   return client.page.personalPage().uploadFile(uploadPath)
 })
 
-When('the user uploads a created file {string} with overwrite using the webUI', function (element) {
-  const uploadPath = path.join(client.globals.mountedUploadDir, element)
-  return client.page
-    .personalPage()
-    .selectFileForUpload(uploadPath)
-    .then(() => client.page.personalPage().confirmFileOverwrite())
-})
+When(
+  'the user uploads a created file {string} with overwrite using the webUI',
+  async function (file) {
+    const uploadPath = path.join(client.globals.mountedUploadDir, file)
+    await client.page.personalPage().selectFileForUpload(uploadPath)
+    await client.page.personalPage().confirmFileOverwrite()
+
+    return this
+  }
+)
 
 When('the public uploads file/folder {string} in files-drop page', function (element) {
   const rootUploadDir = client.globals.mountedUploadDir