Skip to content

Commit

Permalink
Accommodate sticky sidebar header, update test selectors for it
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalwengerter committed Jun 17, 2021
1 parent c0ee167 commit d51e63b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions changelog/unreleased/enhancement-files-sidebar-accessibility
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@ We've did several improvements to enhance the accessibility on the files sidebar
- Clicking outside of the sidebar now closes it
- Removed the aria-label on the action buttons as they already include proper labels
- Added a hint for screen readers if an action opens a new window/tab
- Make sidebar header sticky

https://github.com/owncloud/web/pull/5000
https://github.com/owncloud/web/pull/5266
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/Sidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<oc-app-side-bar
:key="highlightedFile.id"
v-click-outside="onClickOutside"
class="files-sidebar oc-p-s oc-border-l"
class="files-sidebar oc-px-s oc-border-l"
:disable-action="false"
:close-button-label="$gettext('Close file sidebar')"
@close="close()"
Expand Down

0 comments on commit d51e63b

Please sign in to comment.