feat: only allow extensionPoint instances when querying extensions

owncloud · May 15, 2024 · ae2f48b · ae2f48b
1 parent c9c0af4
commit ae2f48b
Show file tree

Hide file tree

Showing 41 changed files with 624 additions and 569 deletions.
diff --git a/changelog/unreleased/change-disable-opening-files-in-embed-mode b/changelog/unreleased/change-disable-opening-files-in-embed-mode
@@ -1,6 +1,6 @@
 Change: Disable opening files in embed mode
 
-We have disabled to open files in the embed mode, since opening or editing files is not in scope of the embed mode
+We have disabled to open files in the embed mode, since opening or editing files is not in scope of the embed mode.
 
 https://github.com/owncloud/web/pull/10786
 https://github.com/owncloud/web/issues/10635
diff --git a/changelog/unreleased/change-remove-portal-targets b/changelog/unreleased/change-remove-portal-targets
@@ -0,0 +1,9 @@
+Change: Portal target removed
+
+BREAKING CHANGE for developers: The (undocumented) portal target `app.runtime.header` is not available anymore. Please use the extension point `app.runtime.header.center` with `customComponent` extensions instead (for details see below).
+
+The portal target `app.runtime.header` has been removed in favour of a new extension point with the id `app.runtime.header.center`. The extension point
+is capable of mounting extensions of type `customComponent`. The search bar, which was previously using this portal target, was rewired into an extension. Other `portal` instances which used this portal target won't work anymore
+and need to be ported to the `customComponent` extension type instead.
+
+https://github.com/owncloud/web/pull/10758
diff --git a/docs/extension-system/_index.md b/docs/extension-system/_index.md
@@ -148,6 +148,7 @@ your extension will be used automatically.
    7. Upload menu. ExtensionPointId `app.files.upload-menu`. Mounts extensions of type `action`.
    8. Quick actions. ExtensionPointId `app.files.quick-actions`. Mounts extensions of type `action`.
 3. Global progress bar for the global loading state. ExtensionPointId `app.runtime.global-progress-bar`. Mounts a single extensions of type `customComponent`. If multiple exist, the user can choose via the account page.
+4. Global search providers. ExtensionPointId `app.search.providers`. Utilizes extensions of type `search` as search engines for the search input in the global top bar.
 
 #### User Preferences for Extensions
 

diff --git a/package.json b/package.json
@@ -114,7 +114,7 @@
   "engines": {
     "node": ">=18"
   },
-  "packageManager": "pnpm@9.0.6",
+  "packageManager": "pnpm@9.1.1",
   "volta": {
     "node": "18.19.0"
   },

diff --git a/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue b/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
@@ -320,9 +320,7 @@ export default defineComponent({
     const extensionActions = computed(() => {
       return [
         ...extensionRegistry
-          .requestExtensions<ActionExtension>({
-            extensionPoint: uploadMenuExtensionPoint
-          })
+          .requestExtensions<ActionExtension>(uploadMenuExtensionPoint)
           .map((e) => e.action)
       ].filter((e) => e.isVisible())
     })

diff --git a/packages/web-app-files/src/components/FilesList/QuickActions.vue b/packages/web-app-files/src/components/FilesList/QuickActions.vue
@@ -40,9 +40,7 @@ export default defineComponent({
 
     const filteredActions = computed(() => {
       return unref(extensionRegistry)
-        .requestExtensions<ActionExtension>({
-          extensionPoint: quickActionsExtensionPoint
-        })
+        .requestExtensions<ActionExtension>(quickActionsExtensionPoint)
         .map((e) => e.action)
         .filter(({ isVisible }) => isVisible({ space: props.space, resources: [props.item] }))
     })