Skip to content

Commit

Permalink
Vue 3: Fix 'Shift + click'-selection in files table (#8207)
Browse files Browse the repository at this point in the history
* Fix 'Shift + click'-selection in files table
  • Loading branch information
JammingBen authored Jan 11, 2023
1 parent 71de4ba commit 8fcd608
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
11 changes: 9 additions & 2 deletions changelog/unreleased/change-update-vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
Change: Update Vue to v2.7.14
Change: Update Vue to v3.2.45 (via compat mode)

Vue has been updated to 2.7.14
Vue has been updated to v3.2.45. It is currently running in the so-called "compat mode", which guarantees compatibility with Vue 2.7. More detailed information can be found in the referenced issues and PRs down below.

BREAKING CHANGE for developers: The `vue/composition-api` plugin is not available anymore as the composition-api now comes with Vue.

https://github.com/owncloud/web/issues/7948
https://github.com/owncloud/web/issues/5269
https://github.com/owncloud/web/pull/8128
https://github.com/owncloud/web/pull/7877
https://github.com/owncloud/web/pull/8207
https://github.com/owncloud/web/pull/8201
https://github.com/owncloud/web/pull/8202
https://github.com/owncloud/web/pull/8198
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export default defineComponent({
handleShiftClickAction(resource) {
const parent = document.querySelectorAll(`[data-item-id='${resource.id}']`)[0]
const resourceNodes = Object.values(parent.parentNode.childNodes) as HTMLElement[]
const resourceNodes = Object.values(parent.parentNode.children)
const latestNode = resourceNodes.find(
(r) => r.getAttribute('data-item-id') === this.latestSelectedId
)
Expand Down

0 comments on commit 8fcd608

Please sign in to comment.