Removed unused test and moved favorite check to context file

owncloud · May 12, 2020 · 82bdf04 · 82bdf04
1 parent 903e177
commit 82bdf04
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 29 deletions.
diff --git a/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js b/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js
@@ -69,24 +69,6 @@ module.exports = {
         .waitForElementVisible('@favoriteStarShining')
         .click('@sidebarToggleFavoriteButton')
         .waitForElementVisible('@favoriteStarDimm')
-    },
-
-    /**
-     * Asserts whether the resource in the sidebar is marked as favorite
-     * @param {Boolean} shouldBeMarked
-     */
-    isMarkedAsFavorite: function(shouldBeMarked) {
-      if (shouldBeMarked) {
-        this.expect.element('@favoriteStarShining').to.be.visible
-        this.closeSidebar(500)
-
-        return this
-      }
-
-      this.expect.element('@favoriteStarDimm').to.be.visible
-      this.closeSidebar(500)
-
-      return this
     }
   },
   elements: {

diff --git a/tests/acceptance/stepDefinitions/filesContext.js b/tests/acceptance/stepDefinitions/filesContext.js
@@ -318,15 +318,6 @@ When('the user unmarks the favorited file/folder {string} using the webUI', func
   return client.page.FilesPageElement.filesList().unmarkFavorite(path)
 })
 
-When('the user has marked file/folder {string} as favorite using the webUI sidebar', async function(
-  path
-) {
-  const api = client.page.FilesPageElement
-  await api.filesList().clickRow(path)
-  api.appSideBar().markFavoriteSidebar()
-  return client
-})
-
 When('the user marks file/folder {string} as favorite using the webUI sidebar', async function(
   path
 ) {
@@ -664,15 +655,17 @@ Then('file/folder {string} should not be marked as favorite', async function(pat
 })
 
 Then('file/folder {string} should be marked as favorite on the webUI', async function(path) {
+  const selector = client.page.FilesPageElement.appSideBar().elements.breadcrumb.favoriteStarShining
   await client.page.FilesPageElement.filesList().clickRow(path)
 
-  return client.page.FilesPageElement.appSideBar().isMarkedAsFavorite(true)
+  return client.expect.element(selector).to.be.visible
 })
 
 Then('file/folder {string} should not be marked as favorite on the webUI', async function(path) {
+  const selector = client.page.FilesPageElement.appSideBar().elements.breadcrumb.favoriteStarDimm
   await client.page.FilesPageElement.filesList().clickRow(path)
 
-  return client.page.FilesPageElement.appSideBar().isMarkedAsFavorite()
+  return client.expect.element(selector).to.be.visible
 })
 
 Then(/there should be (\d+) files\/folders listed on the webUI/, async function(noOfItems) {