Skip to content

Commit

Permalink
Changelog and test fix
Browse files Browse the repository at this point in the history
  • Loading branch information
kulmann committed Jun 23, 2022
1 parent 9d269c9 commit 7f9378d
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
5 changes: 5 additions & 0 deletions changelog/unreleased/bugfix-external-app-title
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Re-introduce dynamic app name in document title

The `external` app was missing the dynamic app name after some recent refactoring. It has been reintroduced.

https://github.com/owncloud/web/pull/7173
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-external-apps
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: External apps fixes

Bug introduced in #6870. A method used to communicate with the backend was not properly added to the extension after being moved to a different location.

https://github.com/owncloud/web/pull/7166
https://github.com/owncloud/web/pull/7173
7 changes: 4 additions & 3 deletions packages/web-app-external/tests/unit/app.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ describe('The app provider extension', () => {
Promise.resolve({
ok: true,
status: 200,
json: () => providerSuccessResponseGet
data: providerSuccessResponseGet
})
)

Expand All @@ -158,7 +158,7 @@ describe('The app provider extension', () => {
Promise.resolve({
ok: true,
status: 200,
json: () => providerSuccessResponsePost
data: providerSuccessResponsePost
})
)
const wrapper = createShallowMountWrapper(makeRequest)
Expand All @@ -178,7 +178,8 @@ function createShallowMountWrapper(makeRequest, options = {}) {
$route
},
computed: {
currentFileContext: () => $route.params
currentFileContext: () => $route.params,
applicationName: () => $route.query.app
},
methods: {
getFileInfo: mockFileInfo,
Expand Down

0 comments on commit 7f9378d

Please sign in to comment.