Merge pull request #7861 from owncloud/non-200-app-extermnal-response…

…-handling continue on non 2xx responses
owncloud · Oct 25, 2022 · 74cfb1d · 74cfb1d
2 parents ab3ac71 + 9e0a351
commit 74cfb1d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/changelog/unreleased/bugfix-external-app-error-handling b/changelog/unreleased/bugfix-external-app-error-handling
@@ -0,0 +1,6 @@
+Bugfix: Handle non 2xx external app responses
+
+Axios no longer skips on non 200 status responses in app-external.
+If the status is not 2xx, the application now displays a proper error message.
+
+https://github.com/owncloud/web/pull/7861
diff --git a/packages/web-app-external/src/App.vue b/packages/web-app-external/src/App.vue
@@ -112,7 +112,9 @@ export default defineComponent({
         ...(this.applicationName && { app_name: this.applicationName })
       })
       const url = `${baseUrl}?${query}`
-      const response = await this.makeRequest('POST', url)
+      const response = await this.makeRequest('POST', url, {
+        validateStatus: () => true
+      })
 
       if (response.status !== 200) {
         this.errorMessage = response.message

diff --git a/packages/web-runtime/src/helpers/additionalTranslations.ts b/packages/web-runtime/src/helpers/additionalTranslations.ts
@@ -4,6 +4,9 @@ function $gettext(msg: string): string {
 }
 
 export const additionalTranslations = {
+  fileInProcessing: $gettext(
+    'This file is currently being processed and is not yet available for use. Please try again shortly.'
+  ),
   activities: $gettext('Activities'),
   noActivities: $gettext('No activities'),
   virusDetectedActivity: $gettext(