Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address reviews
Browse files Browse the repository at this point in the history
SwikritiT committed Sep 7, 2022

Verified

This commit was signed with the committer’s verified signature.
SwikritiT Swikriti
1 parent 380d78a commit 5ff98f9
Showing 2 changed files with 7 additions and 12 deletions.
14 changes: 7 additions & 7 deletions tests/e2e/cucumber/features/integrations/search.feature
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ Feature: link
| FolDer |
| folderPublic |
# Uncomment the following step after this issue is fixed https://github.com/owncloud/ocis/issues/4517
# But following resource should not be listed in the search list for user "Alice"
# But following resources should not be displayed in the search list for user "Alice"
# | resource |
# | public |
When "Alice" creates the following resources
@@ -44,16 +44,16 @@ Feature: link
But following resources should not be displayed in the search list for user "Alice"
| resource |
| test-folder |
And "Alice" opens the "files" app
When "Alice" opens the "files" app
And "Alice" searches "foldeR" using the global search
Then following resources should be displayed in the search list for user "Alice"
| resource |
| folder |
| new-folder |
| FolDer |
| folderPublic |
And "Alice" opens the "files" app
When "Alice" uploads the following resources
When "Alice" opens the "files" app
And "Alice" uploads the following resources
| resource |
| new-lorem.txt |
| new-lorem-big.txt |
@@ -65,9 +65,9 @@ Feature: link
| new-lorem-big.txt |
| new-data.zip |
| new-folder |
And "Alice" opens the "files" app
When "Alice" enables the option to display the hidden file
When "Alice" uploads the following resources
When "Alice" opens the "files" app
And "Alice" enables the option to display the hidden file
And "Alice" uploads the following resources
| resource |
| .hidden-file.txt |
And "Alice" searches "hidden" using the global search
5 changes: 0 additions & 5 deletions tests/e2e/support/objects/app-files/resource/actions.ts
Original file line number Diff line number Diff line change
@@ -375,11 +375,6 @@ export const emptyTrashBinResources = async (page): Promise<string> => {
return message.trim().toLowerCase()
}

export interface deleteResourceTrashbinArgs {
resource: string
page: Page
}

export const deleteResourceTrashbin = async (args: deleteResourceArgs): Promise<string> => {
const { page, resource } = args
const resourceCheckbox = page.locator(util.format(checkBoxForTrashbin, resource))

0 comments on commit 5ff98f9

Please sign in to comment.