Address review

owncloud · Jan 9, 2023 · 5fc4642 · 5fc4642
1 parent a4fdc34
commit 5fc4642
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/tests/e2e/cucumber/steps/ui/shares.ts b/tests/e2e/cucumber/steps/ui/shares.ts
@@ -161,7 +161,9 @@ Then(
     const shareObject = new objects.applicationFiles.Share({ page })
     for (const { resource, owner } of stepTable.hashes()) {
       const isAcceptedSharePresent = await shareObject.isAcceptedSharePresent(resource, owner)
-      expect(isAcceptedSharePresent).toBe(shouldExist)
+      expect(isAcceptedSharePresent, '${resource} does not exist in accepted share').toBe(
+        shouldExist
+      )
     }
   }
 )
diff --git a/tests/e2e/support/objects/app-files/share/utils.ts b/tests/e2e/support/objects/app-files/share/utils.ts
@@ -1,7 +1,7 @@
 import { errors, Page } from 'playwright'
 import util from 'util'
 
-const acceptedShareList =
+const acceptedShareItem =
   '//*[@data-test-resource-name="%s"]/ancestor::tr//span[@data-test-user-name="%s"]'
 export const acceptedShareExists = async ({
   page,
@@ -16,7 +16,7 @@ export const acceptedShareExists = async ({
 }): Promise<boolean> => {
   let exist = true
   await page
-    .waitForSelector(util.format(acceptedShareList, resource, owner), { timeout })
+    .waitForSelector(util.format(acceptedShareItem, resource, owner), { timeout })
     .catch((e) => {
       if (!(e instanceof errors.TimeoutError)) {
         throw e