Skip to content

Commit

Permalink
fix: use share role name prop for html id
Browse files Browse the repository at this point in the history
kulmann committed Mar 22, 2023
1 parent 1bd95d0 commit 5aa0cb3
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<oc-list class="roleDropdownList">
<li v-for="roleOption in availableRoleOptions" :key="`role-dropdown-${roleOption.key}`">
<oc-button
:id="`files-role-${roleOption.key}`"
:id="`files-role-${roleOption.name}`"
:class="{
selected: isSelectedRole(roleOption),
'oc-background-primary-gradient': isSelectedRole(roleOption)
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ exports[`DetailsAndEdit component if user can edit renders dropdown and edit but
<oc-drop-stub class="edit-public-link-role-dropdown" closeonclick="false" dropid="edit-public-link-role-dropdown" isnested="false" mode="click" offset="0" paddingsize="small" position="bottom-start" toggle="#edit-public-link-role-dropdown-toggle-undefined">
<oc-list-stub class="roleDropdownList" raw="false">
<li>
<oc-button-stub appearance="raw" class="oc-p-s" disabled="false" gapsize="medium" id="files-role-none-file" justifycontent="space-between" size="medium" submit="button" type="button" variation="passive">
<oc-button-stub appearance="raw" class="oc-p-s" disabled="false" gapsize="medium" id="files-role-internal" justifycontent="space-between" size="medium" submit="button" type="button" variation="passive">
<span class="oc-flex oc-flex-middle">
<oc-icon-stub accessiblelabel="" class="oc-pl-s oc-pr-m" color="" filltype="fill" name="user" size="medium" type="span" variation="inherit"></oc-icon-stub>
<span>
@@ -24,7 +24,7 @@ exports[`DetailsAndEdit component if user can edit renders dropdown and edit but
</oc-button-stub>
</li>
<li>
<oc-button-stub appearance="raw-inverse" class="selected oc-background-primary-gradient oc-p-s" disabled="false" gapsize="medium" id="files-role-viewer-file" justifycontent="space-between" size="medium" submit="button" type="button" variation="primary">
<oc-button-stub appearance="raw-inverse" class="selected oc-background-primary-gradient oc-p-s" disabled="false" gapsize="medium" id="files-role-viewer" justifycontent="space-between" size="medium" submit="button" type="button" variation="primary">
<span class="oc-flex oc-flex-middle">
<oc-icon-stub accessiblelabel="" class="oc-pl-s oc-pr-m" color="" filltype="fill" name="eye" size="medium" type="span" variation="inherit"></oc-icon-stub>
<span>
@@ -38,7 +38,7 @@ exports[`DetailsAndEdit component if user can edit renders dropdown and edit but
</oc-button-stub>
</li>
<li>
<oc-button-stub appearance="raw" class="oc-p-s" disabled="false" gapsize="medium" id="files-role-editor-file" justifycontent="space-between" size="medium" submit="button" type="button" variation="passive">
<oc-button-stub appearance="raw" class="oc-p-s" disabled="false" gapsize="medium" id="files-role-editor" justifycontent="space-between" size="medium" submit="button" type="button" variation="passive">
<span class="oc-flex oc-flex-middle">
<oc-icon-stub accessiblelabel="" class="oc-pl-s oc-pr-m" color="" filltype="fill" name="pencil" size="medium" type="span" variation="inherit"></oc-icon-stub>
<span>
4 changes: 2 additions & 2 deletions packages/web-client/src/helpers/share/role.ts
Original file line number Diff line number Diff line change
@@ -194,15 +194,15 @@ export const peopleRoleDenyFolder = new PeopleShareRole(
[SharePermissions.denied]
)
export const linkRoleInternalFile = new LinkShareRole(
'none',
'internal',
false,
$gettext('Internal'),
$gettext('internal'),
'user',
[SharePermissions.internal]
)
export const linkRoleInternalFolder = new LinkShareRole(
'none',
'internal',
true,
$gettext('Internal'),
$gettext('internal'),

0 comments on commit 5aa0cb3

Please sign in to comment.