Restructure user store for e2e tests (#8871)

tests/e2e/cucumber/features/smoke/admin-settings/users.ocis.feature

@@ -91,10 +91,10 @@ Feature: users management
     And "Admin" opens the "admin-settings" app
     And "Admin" navigates to the users management page
     When "Admin" changes userName to "anna" for user "Alice" using the sidebar panel
-    And "Admin" changes displayName to "Anna Murphy" for user "Alice" using the sidebar panel
-    And "Admin" changes email to "[email protected]" for user "Alice" using the sidebar panel
-    And "Admin" changes password to "password" for user "Alice" using the sidebar panel
-    And "Admin" changes role to "Space Admin" for user "Alice" using the sidebar panel
+    And "Admin" changes displayName to "Anna Murphy" for user "anna" using the sidebar panel
+    And "Admin" changes email to "[email protected]" for user "anna" using the sidebar panel
+    And "Admin" changes password to "password" for user "anna" using the sidebar panel
+    And "Admin" changes role to "Space Admin" for user "anna" using the sidebar panel
     And "Admin" logs out
     When "anna" logs in
     Then "anna" should have self info:

tests/e2e/cucumber/steps/ui/public.ts

@@ -15,18 +15,6 @@ When(
       user = this.usersEnvironment.getUser({ key: stepUser })
     } catch (e) {}
 
-    if (!user) {
-      user = this.usersEnvironment.createUser({
-        key: stepUser,
-        user: {
-          id: stepUser,
-          displayName: stepUser,
-          password: '',
-          email: ''
-        }
-      })
-    }
-
     let actor
     try {
       actor = this.actorsEnvironment.getActor(user)

tests/e2e/support/api/graph/userManagement.ts

@@ -4,6 +4,7 @@ import join from 'join-path'
 import { config } from '../../../config'
 import { getApplicationEntity } from './utils'
 import { userRoleStore } from '../../store'
+import { UsersEnvironment } from '../../environment'
 
 export const me = async ({ user }: { user: User }): Promise<Me> => {
   const response = await request({
@@ -32,9 +33,8 @@ export const createUser = async ({ user, admin }: { user: User; admin: User }):
 
   checkResponseStatus(response, 'Failed while creating user')
 
-  const responseData = await response.json()
-  user.uuid = responseData.id
-
+  const usersEnvironment = new UsersEnvironment()
+  usersEnvironment.storeCreatedUser({ user: { ...user, uuid: (await response.json()).id } })
   return user
 }
 
@@ -44,7 +44,10 @@ export const deleteUser = async ({ user, admin }: { user: User; admin: User }):
     path: join('graph', 'v1.0', 'users', user.id),
     user: admin
   })
-
+  try {
+    const usersEnvironment = new UsersEnvironment()
+    usersEnvironment.removeCreatedUser({ key: user.id })
+  } catch (e) {}
   return user
 }
 

tests/e2e/support/api/userManagement.ts

@@ -2,6 +2,7 @@ import { checkResponseStatus, checkOCJsonStatus, request } from './http'
 import { Group, User } from '../types'
 import { URLSearchParams } from 'url'
 import join from 'join-path'
+import { UsersEnvironment } from '../environment'
 
 export const createUser = async ({ user, admin }: { user: User; admin: User }): Promise<void> => {
   const promChain = []
@@ -21,8 +22,11 @@ export const createUser = async ({ user, admin }: { user: User; admin: User }):
     })
     checkResponseStatus(response, 'Failed while creating user')
 
-    const json = await response.json()
-    checkOCJsonStatus(json, 'Failed while creating user')
+    const jsonResponse = await response.json()
+    checkOCJsonStatus(jsonResponse, 'Failed while creating user')
+
+    const usersEnvironment = new UsersEnvironment()
+    usersEnvironment.storeCreatedUser({ user: { ...user, uuid: jsonResponse.id } })
   }
 
   ;[
@@ -55,7 +59,10 @@ export const deleteUser = async ({ user, admin }: { user: User; admin: User }):
     path: join('ocs', 'v2.php', 'cloud', 'users', encodeURIComponent(user.id)),
     user: admin
   })
-
+  try {
+    const usersEnvironment = new UsersEnvironment()
+    usersEnvironment.removeCreatedUser({ key: user.id })
+  } catch (e) {}
   return user
 }
 

tests/e2e/support/environment/userManagement.ts

@@ -1,29 +1,69 @@
 import { Group, User } from '../types'
 import { dummyUserStore, dummyGroupStore } from '../store'
+import { createdUserStore } from '../store/user'
 
 export class UsersEnvironment {
   getUser({ key }: { key: string }): User {
-    const uniqueKey = key.toLowerCase()
+    const userKey = key.toLowerCase()
 
-    if (!dummyUserStore.has(uniqueKey)) {
-      throw new Error(`user with key '${uniqueKey}' not found`)
+    if (!dummyUserStore.has(userKey)) {
+      throw new Error(`user with key '${userKey}' not found`)
     }
 
-    return dummyUserStore.get(uniqueKey)
+    return dummyUserStore.get(userKey)
   }
 
   createUser({ key, user }: { key: string; user: User }): User {
-    const uniqueKey = key.toLowerCase()
+    const userKey = key.toLowerCase()
 
-    if (dummyUserStore.has(uniqueKey)) {
-      throw new Error(`user with key '${uniqueKey}' already exists`)
+    if (dummyUserStore.has(userKey)) {
+      throw new Error(`user with key '${userKey}' already exists`)
+    }
+
+    dummyUserStore.set(userKey, user)
+
+    return user
+  }
+
+  storeCreatedUser({ user }: { user: User }): User {
+    if (createdUserStore.has(user.id)) {
+      throw new Error(`user '${user.id}' already exists`)
+    }
+    createdUserStore.set(user.id, user)
+
+    return user
+  }
+
+  getCreatedUser({ key }: { key: string }): User {
+    const userKey = key.toLowerCase()
+    if (!createdUserStore.has(userKey)) {
+      throw new Error(`user with key '${userKey}' not found`)
     }
 
-    dummyUserStore.set(uniqueKey, user)
+    return createdUserStore.get(userKey)
+  }
+
+  updateCreatedUser({ key, user }: { key: string; user: User }): User {
+    const userKey = key.toLowerCase()
+    if (!createdUserStore.has(userKey)) {
+      throw new Error(`user '${userKey}' not found`)
+    }
+    createdUserStore.delete(userKey)
+    createdUserStore.set(user.id, user)
 
     return user
   }
 
+  removeCreatedUser({ key }: { key: string }): boolean {
+    const userKey = key.toLowerCase()
+
+    if (!createdUserStore.has(userKey)) {
+      throw new Error(`user '${userKey}' not found`)
+    }
+
+    return createdUserStore.delete(userKey)
+  }
+
   getGroup({ key }: { key: string }): Group {
     const uniqueKey = key.toLowerCase()
 

tests/e2e/support/objects/app-admin-settings/users/actions.ts

@@ -35,27 +35,39 @@ const displayNameInput = '#create-user-input-display-name'
 const emailInput = '#create-user-input-email'
 const passwordInput = '#create-user-input-password'
 
+export interface UserInterface {
+  displayName: string
+  givenName: string
+  id: string
+  mail: string
+  onPremisesSamAccountName: string
+  surname: string
+  userType: string
+}
+
 export const createUser = async (args: {
   page: Page
   name: string
   displayname: string
   email: string
   password: string
-}): Promise<void> => {
+}): Promise<UserInterface> => {
   const { page, name, displayname, email, password } = args
   await page.locator(createUserButton).click()
   await page.locator(userNameInput).fill(name)
   await page.locator(displayNameInput).fill(displayname)
   await page.locator(emailInput).fill(email)
   await page.locator(passwordInput).fill(password)
 
-  await Promise.all([
+  const [response] = await Promise.all([
     page.waitForResponse(
       (resp) =>
         resp.url().endsWith('users') && resp.status() === 200 && resp.request().method() === 'POST'
     ),
-    await page.locator(actionConfirmButton).click()
+    page.locator(actionConfirmButton).click()
   ])
+
+  return await response.json()
 }
 export const changeAccountEnabled = async (args: {
   page: Page

tests/e2e/support/objects/app-admin-settings/users/index.ts

@@ -27,7 +27,7 @@ export class Users {
     this.#page = page
   }
   getUUID({ key }: { key: string }): string {
-    return this.#usersEnvironment.getUser({ key }).uuid
+    return this.#usersEnvironment.getCreatedUser({ key }).uuid
   }
 
   async allowLogin({ key, action }: { key: string; action: string }): Promise<void> {
@@ -104,9 +104,19 @@ export class Users {
     action: string
   }): Promise<void> {
     const uuid = this.getUUID({ key })
+
     await openEditPanel({ page: this.#page, uuid, action })
     await changeUser({ uuid, attribute: attribute, value: value, page: this.#page })
+    const currentUser = this.#usersEnvironment.getCreatedUser({ key })
+
+    if (attribute !== 'role') {
+      this.#usersEnvironment.updateCreatedUser({
+        key: key,
+        user: { ...currentUser, [attribute === 'userName' ? 'id' : attribute]: value }
+      })
+    }
   }
+
   async addToGroups({
     key,
     groups,
@@ -139,6 +149,7 @@ export class Users {
   async deleteUserUsingBatchAction({ userIds }: { userIds: string[] }): Promise<void> {
     await deleteUserUsingBatchAction({ page: this.#page, userIds })
   }
+
   async createUser({
     name,
     displayname,
@@ -150,7 +161,17 @@ export class Users {
     email: string
     password: string
   }): Promise<void> {
-    await createUser({ page: this.#page, name, displayname, email, password })
+    const response = await createUser({ page: this.#page, name, displayname, email, password })
+
+    this.#usersEnvironment.storeCreatedUser({
+      user: {
+        id: response.onPremisesSamAccountName,
+        displayName: response.displayName,
+        password: password,
+        email: response.mail,
+        uuid: response.id
+      }
+    })
   }
 
   async openEditPanel({ key, action }: { key: string; action: string }): Promise<void> {