Skip to content

Commit

Permalink
Address PR issues
Browse files Browse the repository at this point in the history
  • Loading branch information
lookacat committed Jan 12, 2023
1 parent a1b8a8f commit 43b39a4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
3 changes: 1 addition & 2 deletions packages/web-app-admin-settings/src/views/Spaces.vue
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ export default defineComponent({
toggleSelectSpace,
unselectAllSpaces
}
},
methods: {}
}
})
</script>
10 changes: 10 additions & 0 deletions packages/web-pkg/src/components/sideBar/Details/SpaceDetails.vue
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,16 @@ export default defineComponent({
return formatDateFromISO(this.space.mdate, this.$language.current)
},
ownerUsernames() {
// TODO: Find a better solution for reactiveness
if (this.spaceResource) {
const allManagers = this.space.spaceRoles[spaceRoleManager.name]
const managers = allManagers.length > 2 ? allManagers.slice(0, 2) : allManagers
let managerStr = managers.map((m) => m.displayName).join(', ')
if (allManagers.length > 2) {
managerStr += `... +${allManagers.length - 2}`
}
return managerStr
}
const userId = this.user?.id
return this.spaceMembers
.filter((share) => share.role.name === spaceRoleManager.name)
Expand Down

0 comments on commit 43b39a4

Please sign in to comment.