Address code review

owncloud · Dec 14, 2022 · 36d901e · 36d901e
1 parent 9971b3f
commit 36d901e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue b/packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
@@ -50,33 +50,33 @@ export default defineComponent({
     }
   },
   computed: {
-    iconName(): string {
+    iconName() {
       if (this.isSpace) return defaultSpaceIcon
       if (this.isFolder) return defaultFolderIcon
       const icon = iconNameMap[this.extension]
       return `resource-type-${icon ? icon : defaultFallbackIcon}`
     },
-    iconColor(): string {
+    iconColor() {
       if (this.isSpace) return defaultSpaceColor
       if (this.isFolder) return defaultFolderColor
       const color = iconColorMap[this.extension]
       return color ? color : defaultFallbackIconColor
     },
-    iconTypeClass(): string {
+    iconTypeClass() {
       if (this.isSpace) return 'oc-resource-icon-space'
       if (this.isFolder) return 'oc-resource-icon-folder'
       return 'oc-resource-icon-file'
     },
-    isFolder(): boolean {
+    isFolder() {
       // fallback is necessary since
       // sometimes resources without a type
       // but with `isFolder` are being passed
       return this.resource.type === 'folder' || this.resource.isFolder
     },
-    isSpace(): boolean {
+    isSpace() {
       return this.resource.type === 'space'
     },
-    extension(): string {
+    extension() {
       return this.resource.extension?.toLowerCase()
     }
   }

diff --git a/packages/web-app-files/tests/unit/components/AppBar/ViewOptions.spec.js b/packages/web-app-files/tests/unit/components/AppBar/ViewOptions.spec.js
@@ -110,7 +110,7 @@ describe('ViewOptions', () => {
     expect(wrapper.find('[data-testid="viewmode-switch-buttons"]').exists()).toBeFalsy()
   })
 
-  it('shows a viewmode switcher if more than one viewModes are passes', () => {
+  it('shows a viewmode switcher if more than one viewModes are passed', () => {
     const wrapper = shallowMount(ViewOptions, {
       propsData: {
         viewModes: ['one', 'two']

diff --git a/packages/web-app-files/tests/unit/components/AppBar/__snapshots__/ViewOptions.spec.js.snap b/packages/web-app-files/tests/unit/components/AppBar/__snapshots__/ViewOptions.spec.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`ViewOptions shows a viewmode switcher if more than one viewModes are passes 1`] = `
+exports[`ViewOptions shows a viewmode switcher if more than one viewModes are passed 1`] = `
 <div data-testid="viewmode-switch-buttons" class="oc-button-group oc-visible@s oc-mr-s">
   <oc-button-stub appearance="outline">
     <oc-icon-stub name="menu-line-condensed" fill-type="none" size="small"></oc-icon-stub>