Fix xpath selection for actionPanelItems to get the tests running again

owncloud · Apr 23, 2021 · 336eca8 · 336eca8
1 parent 90b5efa
commit 336eca8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/web-app-files/src/components/Sidebar/ActionsAccordion.vue b/packages/web-app-files/src/components/Sidebar/ActionsAccordion.vue
@@ -8,7 +8,9 @@
         @click.stop="action.handler(highlightedFile, action.handlerData)"
       >
         <oc-icon :name="action.icon" size="medium" />
-        {{ action.label(highlightedFile) }}
+        <span class="oc-files-actions-sidebar-action-label">{{
+          action.label(highlightedFile)
+        }}</span>
         <span
           v-if="action.opensInNewWindow"
           class="oc-invisible-sr"

diff --git a/tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature b/tests/acceptance/features/webUIFilesActionMenu/fileFolderActionMenu.feature
@@ -26,9 +26,9 @@ Background: prepare user and files
     When the user picks the row of file "lorem.pdf" in the webUI
     Then the app-sidebar for file "lorem.pdf" should be visible on the webUI
     And only the following items with default items should be visible in the actions menu on the webUI
-      | items                                           |
-      | open in browser (opens in new window)           |
-      | download                                        |
+      | items                     |
+      | open in browser           |
+      | download                  |
     When the user picks the row of file "testavatar.png" in the webUI
     Then the app-sidebar for file "testavatar.png" should be visible on the webUI
     And only the following items with default items should be visible in the actions menu on the webUI

diff --git a/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js b/tests/acceptance/pageObjects/FilesPageElement/appSideBar.js
@@ -199,7 +199,7 @@ module.exports = {
     },
     actionPanelItems: {
       selector:
-        '//div[@class="oc-accordion-content"]//li/button | //div[@class="oc-accordion-content"]//li/a',
+        '//div[@class="oc-accordion-content"]//li/button/span[@class="oc-files-actions-sidebar-action-label"] | //div[@class="oc-accordion-content"]//li/a/span[@class="oc-files-actions-sidebar-action-label"]',
       locateStrategy: 'xpath'
     }
   }