Change from IDs to classes in quick action buttons

owncloud · Apr 27, 2021 · 1129851 · 1129851
1 parent 9e0f11c
commit 1129851
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/changelog/unreleased/bugfix-quick-action-ids b/changelog/unreleased/bugfix-quick-action-ids
@@ -0,0 +1,6 @@
+Bugfix: Change quick action from IDs to classes
+
+Quick action button IDs were repeated in every row of the file table, which isn't allowed in HTML (IDs must be unique per document).
+By changing to classes, this offense was resolved.
+
+https://github.com/owncloud/web/pull/5028
diff --git a/packages/web-app-files/src/components/FilesLists/QuickActions.vue b/packages/web-app-files/src/components/FilesLists/QuickActions.vue
@@ -2,12 +2,12 @@
   <div class="uk-flex">
     <oc-button
       v-for="action in filteredActions"
-      :id="`files-quick-action-${action.id}`"
       :key="action.label"
       :aria-label="action.label"
       :uk-tooltip="action.label"
       appearance="raw"
       class="oc-mr-xs"
+      :class="`files-quick-action-${action.id}`"
       @click.stop="action.handler({ item, client: $client, store: $store })"
     >
       <oc-icon :name="action.icon" class="uk-flex" />

diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesRow.js b/tests/acceptance/pageObjects/FilesPageElement/filesRow.js
@@ -50,7 +50,7 @@ module.exports = {
       locateStrategy: 'xpath'
     },
     quickAction: {
-      selector: '//button[@id="files-quick-action-%s"]',
+      selector: '//button[@class="files-quick-action-%s"]',
       locateStrategy: 'xpath'
     }
   }