Public link change password validation bugfix

owncloud · Apr 19, 2023 · 0bc62b0 · 0bc62b0
1 parent 827d57c
commit 0bc62b0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/changelog/unreleased/bugfix-public-link-empty-password-message-stays-forever b/changelog/unreleased/bugfix-public-link-empty-password-message-stays-forever
@@ -0,0 +1,6 @@
+Bugfix: Public link empty password stays forever
+
+We've fixed a bug that caused the error message for the public link password to stay forever.
+
+https://github.com/owncloud/web/pull/8864
+https://github.com/owncloud/web/issues/8521
diff --git a/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue b/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
@@ -457,7 +457,7 @@ export default defineComponent({
       if (password.length > 72) {
         return this.setModalInputErrorMessage(this.$gettext("Password can't exceed 72 characters"))
       }
-      return this.setModalInputErrorMessage(null)
+      return this.setModalInputErrorMessage('')
     },
 
     showPasswordModal() {
@@ -467,7 +467,6 @@ export default defineComponent({
         cancelText: this.$gettext('Cancel'),
         confirmText: this.link.password ? this.$gettext('Apply') : this.$gettext('Set'),
         hasInput: true,
-        inputDescription: this.$gettext("Password can't be empty"),
         inputLabel: this.$gettext('Password'),
         inputType: 'password',
         onCancel: this.hideModal,
@@ -484,8 +483,8 @@ export default defineComponent({
           })
         }
       }
-
       this.createModal(modal)
+      this.setModalInputErrorMessage(this.$gettext("Password can't be empty"))
     }
   }
 })