Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an exact match of the search term for the uuid attribute #238

Closed
wants to merge 1 commit into from

Conversation

jvillafanez
Copy link
Member

Fix user:sync by allowing searching by the uuid (exact match)

Note of possible problems if the same attribute is used in the "user search attributes" checkbox

Superseds #236

@tomneedham
Copy link
Contributor

Motivation / use case here? Is this to improve usability of the single user sync? The admin can add the UUID attribute to the user search attributes to achieve this functionality.

@jvillafanez
Copy link
Member Author

I think it's to improve the usability. I'd expect that if I use the -u option to sync only one user by uid, it's should work by default. I find pretty weird that I can't sync one user by uid using the default options, specially when the option clearly specify to use the user id.

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2019

discuss and decide whether to keep or close

@butonic
Copy link
Member

butonic commented Feb 12, 2019

I like the idea, however it adds 'magic' and IMO the proper solution is to properly distinguish username frome userid in core (which we actually started with https://github.com/owncloud/core/pull/32587/files ... it is just that nobody has realized we are doing it as yet another hack)

We should add apis that now allow median searching or exact searching. might be a parameter or a new function.

close and implement owncloud/core#29503 (comment) That will create new apis, then we can revisit this properly.

@PVince81 PVince81 closed this Feb 18, 2019
@PVince81 PVince81 deleted the fix_uuid_exact_match branch February 18, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants