Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quoted strings like --display-name='User One' #34

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 5, 2018

Description

If we send an occ command fragment like:

--display-name='User One'

Then we do not want to escape it again, because that ends up creating the user with a display name that includes the single quotes literally at each end of the display name.

The work-around is to send:

--display-name 'User One'

But we want to be able to use both ways of writing occ commands, without having to think too much when writing tests.

Checklist:

@phil-davis
Copy link
Contributor Author

Password policy currently uses this form when doing tests that create users with various passwords.
And we are about to start infrastructure for testing occ commands in core, so the testing app needs to work OK for all "reasonable" forms of occ commands.

@phil-davis
Copy link
Contributor Author

See issue #36 to add testing for this and other testing app stuff.

@phil-davis phil-davis merged commit 1037594 into master Oct 5, 2018
@phil-davis phil-davis deleted the allow-more-quoted-strings branch October 5, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants