Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.3 #79

Closed
wants to merge 1 commit into from
Closed

Release 0.5.3 #79

wants to merge 1 commit into from

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Mar 14, 2019

Closes #75

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #79   +/-   ##
========================================
  Coverage      2.96%   2.96%           
  Complexity      225     225           
========================================
  Files            22      22           
  Lines          1011    1011           
========================================
  Hits             30      30           
  Misses          981     981

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48121f4...7a68880. Read the comment docs.

@micbar micbar requested a review from patrickjahns March 14, 2019 09:47
@phil-davis
Copy link
Contributor

Note: because of core stable10 "drop PHP 5.6" all apps have had min-version bumped to 10.2
That includes here https://github.com/owncloud/search_elastic/pull/79/files#diff-224bb875c5d3cfcd7621135069013242

If this release needs to be installable on ownCloud core 10.0 and/or 10.1 then min-version will need to be temporarily adjusted, and:

  • see if any "require" dependencies in composer.json would be different if PHP platform is backed up to 5.6 (if so, then put 5.6 back and regenerate composer.lock)
  • test against actual core 10.1 and/or 10.0.10 releases (not just against current core stable10)

@micbar
Copy link
Contributor Author

micbar commented Mar 14, 2019

@phil-davis The customer for this consulting Release has the latest Oracle Linux with php72 and wants to install it on 10.0.10

@phil-davis
Copy link
Contributor

Then it is not going to "explode" because the target installation will be running PHP 7.2
But it will need core min-version set back to 10.0 so that the app will let itself be enabled.

@PVince81 hear is the first example of this need to release apps "backwards" to 10.* - "standard" process needs to be sorted out?

@micbar
Copy link
Contributor Author

micbar commented Mar 18, 2019

Closing this PR, because we are skipping 0.5.3

@micbar micbar closed this Mar 18, 2019
@micbar micbar deleted the release-0.5.3 branch March 18, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants