[full-ci] Support ES7

[DeepDiver1975]

No description provided.

[DeepDiver1975]

rebased version of #185

[DeepDiver1975]

@phil-davis same as with #185 - no idea why the acceptance tests are failing ..... can I ask you to take a look? THX

[phil-davis]

The failed tests were reported in https://drone.owncloud.com/owncloud/search_elastic/1569/17/13

runsh: Total unexpected failed scenarios throughout the test run:
webUISearchElastic/searchContent.feature:26
webUISearchElastic/searchContent.feature:33
webUISearchElastic/searchContent.feature:40

I applied the latest drone starlark code in PR #216 - that will make it report a comment properly to GitHub when a pipeline fails and the other pipelines are cancelled. I rebased this PR. Now I will review what is here, and see what CI thinks...

[ownclouders]

💥 Acceptance tests pipeline apiLimitSearches-latest-mysql8.0-php7.2-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1574/21/1

[ownclouders]

💥 Acceptance tests pipeline webUISE-master-firefox-mysql8.0-php7.2-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1574/17/1

[phil-davis]

I cleaned up some text in README, just to have a new commit to push and get full-ci.

[phil-davis]

The new Elastic Search shows matches better. When searching for "ipsum" it finds it in lorem.txt and the search results show the actual line that contains "ipsum".

The existing "old" Elastic Search code was showing the first line of the file, rather than the line containing the search string.

I adjusted the test expectations.

[xoxys]

@phil-davis Could you please check why some tests are still failing?

[phil-davis]

Rebase after the .drone.star refactoring was merged in PRs #217 #218

[xoxys]

@phil-davis @DeepDiver1975 @pmaier1 Can we have a release this week please?

[phil-davis]

I ended up reversing the test change in "Adjust indexOnlyMetadata.feature test" commit.
See commit "Adjust test that fails due to issue-40"

I guess that something in "use owncloudops elastic image" made that test scenario go back to behaving the way that it originally behaved. Note: we still have issue #40 - the behavior has not changed for that issue.

If this passes, then I will rebase-squash a bit to get rid of the unneeded commits.

[xoxys]

How is the test case failure related to the base image change? The CI was failing before already https://drone.owncloud.com/owncloud/search_elastic/1581 or what do I miss?

[xoxys]

Is #40 a release blocker? I guess not, as the issue is unrelated to the es7 compatibility update, or?

[phil-davis]

How is the test case failure related to the base image change?

I had actually modified that test scenario to get it passing with deepdiver/elasticsearch - and when you switched to owncloudops/elasticsearch the behavior changed back to what it was previously. I noticed that my last commit just today is effectively a revert of my earlier commit 3eed61b

[phil-davis]

Is #40 a release blocker? I guess not, as the issue is unrelated to the es7 compatibility update, or?

Not a blocker, it is an existing issue if someone wants to "wildcard" search filenames - search for "plan" and find a file called "business-plan.xls" or search for ".xls" and find all the Excel spreadsheets. That is functionality that "someone" can look into separately.

[phil-davis]

I rebased-squashed so that there are 4 logical commits. This is good-to-go when CI finishes.

[phil-davis]

What to do about this? Do we have confidence that this will work with ownCloud 10.3 and PHP 7.2?
Or should we bump the owncloud min-version here?

[xoxys]

Question for @DeepDiver1975

[DeepDiver1975]

10.3 is no longer supported - right? just bump this to the latest and greatest .....

..... or chat with PM. 🤷

[phil-davis]

@pmaier1 I guess we bump oC min_version to 10.7 ? Or 10.8? Or?
Unless there is a specific requirement to support this on some lower oC10.? and we then need to test against that.

[pmaier1]

Well, usually we only bump those numbers if we know that an app version is not working with older core versions, e.g., due to some dependencies that are not fulfilled. The correct way would be to check this. But I don't see a real necessity to support it on lower oC 10 versions so I leave it up to you. Both ways are fine.

[phil-davis]

https://drone.owncloud.com/owncloud/search_elastic/1629/23/12

runsh: Total unexpected failed scenarios throughout the test run:
apiSearchElastic/searchContent.feature:158
apiSearchElastic/searchContent.feature:166
apiSearchElastic/searchSharedFiles.feature:77

I haven't seen those failures before. And they look like "random" examples from scenario outlines. The same test pipeline against latest 10.8.0 core passed. I will restart CI, and repeat a couple of times, to see if there is some intermittent test timing issue.

[phil-davis]

https://drone.owncloud.com/owncloud/search_elastic/1630/22/12

runsh: Total unexpected failed scenarios throughout the test run:
apiLimitSearches/indexOnlyMetadata.feature:270

That is a completely different test scenario in a different test suite. It seems that we have intermittent differences.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
1 Security Hotspot
2 Code Smells

58.6% Coverage
0.0% Duplication

[phil-davis]

The last run of CI passed. IMO when we have clarified the support (or not) for older ES5 and ES6 then we can either merge this, or adjust it to support multiple major ES versions.