Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Build Command to create #119

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Rename Build Command to create #119

merged 1 commit into from
Jul 12, 2019

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jul 11, 2019

Description

Currently we have a occ command to create a fresh Search Index called search:index:build
Let's rename it.

Makes more sense to have these commands

  • search:index:create Create the initial index
  • search:index:reset Resets the Search index
  • search:index:update Runs the updateMetadata and UpdateContent Background Jobs
  • search:index:rebuild Rebuilds the index for a single userid. Used for support etc.

@micbar micbar requested a review from pmaier1 July 11, 2019 07:46
@micbar micbar self-assigned this Jul 11, 2019
@micbar micbar added this to the development milestone Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage     18.93%   18.93%           
  Complexity      268      268           
=========================================
  Files            24       24           
  Lines          1183     1183           
=========================================
  Hits            224      224           
  Misses          959      959
Impacted Files Coverage Δ Complexity Δ
lib/Command/Create.php 0% <0%> (ø) 10 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a707f1f...ad72a19. Read the comment docs.

Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to make sure that we have these things documented prior to the release. Let me know where we are here, please.

@micbar micbar merged commit cc31d1e into master Jul 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/rename-create branch July 12, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants